tcp: default RACK loss recovery
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest8 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | tcp: support DUPACK threshold in RACKDocumentation/ include/ net/ | +29 | 0 replies | |
| 2/8 | tcp: disable RFC6675 loss detectionDocumentation/ net/ | +10 | 0 replies | |
| 3/8 | tcp: simpler NewReno implementationinclude/ net/ net/ | +39 | 0 replies | |
| 4/8 | tcp: account lost retransmit after timeoutinclude/ net/ net/ | +6 | 0 replies | |
| 5/8 | tcp: new helper tcp_timeout_mark_lostnet/ | +29 | 0 replies | |
| 6/8 | tcp: separate loss marking and state update on RTOnet/ | +2 | 0 replies | |
| 7/8 | tcp: new helper tcp_rack_skb_timeoutinclude/ net/ net/ | +14 | 0 replies | |
| 8/8 | tcp: don't mark recently sent packets lost on RTOnet/ | +8 | 0 replies |
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by.
| Patch | Eric Dumazet | Soheil Hassas Yeganeh | Priyaranjan Jha |
|---|---|---|---|
| 1/8 | R-b | R-b | R-b |
| 2/8 | R-b | R-b | R-b |
| 3/8 | R-b | R-b | R-b |
| 4/8 | R-b | R-b | R-b |
| 5/8 | R-b | R-b | R-b |
| 6/8 | R-b | R-b | R-b |
| 7/8 | R-b | R-b | R-b |
| 8/8 | R-b | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH net-next 0/8] tcp: default RACK loss recovery
This patch set implements the features correspond to the draft-ietf-tcpm-rack-03 version of the RACK draft.
https://datatracker.ietf.org/meeting/101/materials/slides-101-tcpm-update-on-tcp-rack-00
1. SACK: implement equivalent DUPACK threshold heuristic in RACK to replace existing RFC6675 recovery (tcp_mark_head_lost).
2. Non-SACK: simplify RFC6582 NewReno implementation
3. RTO: apply RACK's time-based approach to avoid spuriouly marking very recently sent packets lost.
4. with (1)(2)(3), make RACK the exclusive fast recovery mechanism to mark losses based on time on S/ACK. Tail loss probe and F-RTO remain enabled by default as complementary mechanisms to send probes in CA_Open and CA_Loss states. The probes would solicit S/ACKs to trigger RACK time-based loss detection.
All Google web and internal servers have been running RACK-only mode
(4) for a while now. a/b experiments indicate RACK/TLP on average reduces recovery latency by 10% compared to RFC6675. RFC6675 is default-off now but can be enabled by disabling RACK (sysctl net.ipv4.tcp_recovery=0) for unseen issues.
Yuchung Cheng (8):
tcp: support DUPACK threshold in RACK
tcp: disable RFC6675 loss detection
tcp: simpler NewReno implementation
tcp: account lost retransmit after timeout
tcp: new helper tcp_timeout_mark_lost
tcp: separate loss marking and state update on RTO
tcp: new helper tcp_rack_skb_timeout
tcp: don't mark recently sent packets lost on RTO
Documentation/networking/ip-sysctl.txt | 4 +- include/net/tcp.h | 5 ++ net/ipv4/tcp_input.c | 99 ++++++++++++++------------ net/ipv4/tcp_recovery.c | 80 ++++++++++++++++----- 4 files changed, 124 insertions(+), 64 deletions(-)
Signature · 1 line
2.17.0.441.gb46fe60e1d-goog