Clean up Tegra20 cpufreq driver
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest11 patches 3 repliesIn review
- v111 patches 29 repliesSuperseded
Changes in v2 from the cover letter
- Added the new patch to the series: "Remove unnecessary parentheses", please review.
- Addressed review comments to the v1 of the series:
1) Kept undeleted necessary headers in the "Clean up included headers" patch as per Viresh's Kumar request.
2) Renamed tegra20_cpufreq_data to tegra20_cpufreq and moved cpufreq driver structure to the tegra20_cpufreq as per Thierry's Reding request.
- Dropped "ARM: tegra: Create platform device for tegra20-cpufreq driver" patch from the series as Thierry already applied it and submitted in the "ARM: tegra: Core changes for v4.18-rc1" pull request.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | cpufreq: tegra20: Change module descriptiondrivers/ | +1 | 0 replies | |
| 2/11 | cpufreq: tegra20: Clean up whitespaces in the codedrivers/ | +1 | 0 replies | |
| 3/11 | cpufreq: tegra20: Clean up included headersdrivers/ | +4 | 1 reply | |
| 4/11 | cpufreq: tegra20: Remove EMC clock usagedrivers/ | +0 | 0 replies | |
| 5/11 | cpufreq: tegra20: Release clocks properlydrivers/ | +26 | 0 replies | |
| 6/11 | cpufreq: tegra20: Remove unneeded check in tegra_cpu_initdrivers/ | +0 | 0 replies | |
| 7/11 | cpufreq: tegra20: Remove unnecessary parenthesesdrivers/ | +1 | 2 replies | |
| 8/11 | cpufreq: tegra20: Remove unneeded variable initializationdrivers/ | +1 | 0 replies | |
| 9/11 | cpufreq: tegra20: Check if this is Tegra20 machinedrivers/ | +4 | 0 replies | |
| 10/11 | cpufreq: tegra20: Allow cpufreq driver to be built as loadable moduledrivers/ | +1 | 0 replies | |
| 11/11 | cpufreq: tegra20: Wrap cpufreq into platform driverdrivers/ | +86 | 0 replies |
Reviews trailers per patch
All 11 patches have a Reviewed-by or Acked-by.
| Patch | Viresh Kumar | Thierry Reding |
|---|---|---|
| 1/11 | A-b | A-b |
| 2/11 | A-b | A-b |
| 3/11 | A-b | A-b |
| 4/11 | A-b | A-b |
| 5/11 | A-b | A-b |
| 6/11 | A-b | A-b |
| 7/11 | A-b | A-b |
| 8/11 | A-b | A-b |
| 9/11 | A-b | A-b |
| 10/11 | A-b | A-b |
| 11/11 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 00/11] Clean up Tegra20 cpufreq driver
Hello,
Recently Peter Geis (who is working on Tegra30 cpufreq driver) asked me how tegra20-cpufreq driver is getting loaded. After taking a look at the code it became apparent that the drivers code has been rusted a tad and so this series is intended to refresh the drivers code by disallowing module to be loaded on non-Tegra20 machines, by cleaning whitespaces in the code, removing dead EMC code and in the end by allowing tegra20-cpufreq to be built as a loadable module.
Changelog:
v2:
- Added the new patch to the series: "Remove unnecessary parentheses", please review.
- Addressed review comments to the v1 of the series:
1) Kept undeleted necessary headers in the "Clean up included headers" patch as per Viresh's Kumar request.
2) Renamed tegra20_cpufreq_data to tegra20_cpufreq and moved cpufreq driver structure to the tegra20_cpufreq as per Thierry's Reding request.
- Dropped "ARM: tegra: Create platform device for tegra20-cpufreq driver" patch from the series as Thierry already applied it and submitted in the "ARM: tegra: Core changes for v4.18-rc1" pull request.
Dmitry Osipenko (11):
cpufreq: tegra20: Change module description
cpufreq: tegra20: Clean up whitespaces in the code
cpufreq: tegra20: Clean up included headers
cpufreq: tegra20: Remove EMC clock usage
cpufreq: tegra20: Release clocks properly
cpufreq: tegra20: Remove unneeded check in tegra_cpu_init
cpufreq: tegra20: Remove unnecessary parentheses
cpufreq: tegra20: Remove unneeded variable initialization
cpufreq: tegra20: Check if this is Tegra20 machine
cpufreq: tegra20: Allow cpufreq driver to be built as loadable module
cpufreq: tegra20: Wrap cpufreq into platform driver
drivers/cpufreq/Kconfig.arm | 2 +- drivers/cpufreq/tegra20-cpufreq.c | 200 ++++++++++++++++-------------- 2 files changed, 111 insertions(+), 91 deletions(-)
Signature · 1 line
2.17.0