Skip to content

Test improvements for 'sg/complete-paths'

SZEDER Gábor git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2completion: don't return with error from __gitcomp_file_direct()contrib/completion/git-completion.bash+4 -20 replies
2/2t9902-completion: exercise __git_complete_index_file() directlyt/t9902-completion.sh+118 -1072 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Test improvements for 'sg/complete-paths'
Quoted 5 lines
Quoted 3 lines

So, I think for v2 I will rewrite these tests to call __git_complete_index_file() directly instead of using 'test_completion', and will include a test with spaces in path names.

Quite well thought-out reasoning. Thanks.

Unfortunately I couldn't get around to it soon enough, and now the topic 'sg/complete-paths' is already in next, so here are those test improvements on top.

SZEDER Gábor (2):
completion: don't return with error from __gitcomp_file_direct()
t9902-completion: exercise __git_complete_index_file() directly

 contrib/completion/git-completion.bash |   6 +-
 t/t9902-completion.sh                  | 225 +++++++++++++------------
 2 files changed, 122 insertions(+), 109 deletions(-)
Signature · 1 line
2.17.0.799.gd371044c7c

Read the cover letter in its thread