Skip to content

Iotrace improvements

Ramon Fried u-boot 6 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest6 patches 0 repliesNew
  2. v46 patches 0 repliesSuperseded
  3. v3 posting 2/20 of 6 patches 0 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v3 posting 1/24 of 6 patches0 repliesSuperseded
v26 patches0 repliesSuperseded
v15 patches0 repliesSuperseded

Changes in v5 from the cover letter

- Removed common.h include that caused werid compliation problems in other boards (trini)
- Fixed portability issue in printf (trini)

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6cmd: iotrace: add set region commandcmd/iotrace.c+22 -01 reply
2/6iotrace: add IO region limitcommon/iotrace.c include/iotrace.h+51 -01 reply
3/6common: iotrace: add timestamp to iotrace recordscommon/iotrace.c+3 -11 reply
4/6iotrace: move record definitons to header filecommon/iotrace.c include/iotrace.h+28 -271 reply
5/6cmd: iotrace: add dump trace commandcmd/iotrace.c+35 -14 replies
6/6iotrace: fix behaviour when buffer is fullcmd/iotrace.c common/iotrace.c include/iotrace.h+20 -91 reply

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchSimon Glass
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [U-Boot] [PATCH v5 0/6] Iotrace improvements

These set of patches add few improvements to iotrace.
* Region limiting - allows setting an address and size where only
io operations that falls into that address are logged.
* Timestamping - Timestamp every iotrace record with current timestamp
* dumping - iotrace dump command for dumping all records from buffer
in a readable fashion.

In terms of backwards compatibility, the timestamp is not backward compatible as it changes the iotrace record. so if one developed an offline parsing tool it will be broken.
I though of adding #ifdef specific for that, but eventually I didn't.

Changes in v5:
- Removed common.h include that caused werid compliation problems in other boards (trini)
- Fixed portability issue in printf (trini)

Changes in v4:
- Resend complete patchset with patman

Changes in v3:
- fixed wrong usage of WARN_ONCE

Changes in v2:
- introduced needed_size to notify the user about the needed buffer size.

Changes in v1:
- Change timestamp function to get_ticks()

Ramon Fried (6):
cmd: iotrace: add set region command
iotrace: add IO region limit
common: iotrace: add timestamp to iotrace records
iotrace: move record definitons to header file
cmd: iotrace: add dump trace command
iotrace: fix behaviour when buffer is full

 cmd/iotrace.c     | 63 ++++++++++++++++++++++++++++++++++++++++++---
 common/iotrace.c  | 65 +++++++++++++++++++++++++++--------------------
 include/iotrace.h | 57 +++++++++++++++++++++++++++++++++++++++--
 3 files changed, 153 insertions(+), 32 deletions(-)
Signature · 1 line
2.17.1