Skip to content

AHCI: tracing improvements

John Snow qemu-devel 2 versions – Applied

Status from this message: Thanks, applied to my IDE tree:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest16 patches 5 repliesApplied
  2. v116 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- Added qemu_log_mask(LOG_UNIMP, ...) statements in addition to traces for writes to unknown/unsupported registers. (Philippe)

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/16ahci: add port register enumerationhw/ide/ahci.c hw/ide/ahci_internal.h+54 -00 replies
2/16ahci: modify ahci_port_read to use register numbershw/ide/ahci.c+19 -190 replies
3/16ahci: make port read traces more descriptivehw/ide/ahci.c hw/ide/trace-events+5 -30 replies
4/16ahci: fix spacing damage on ahci_port_writehw/ide/ahci.c+71 -710 replies
5/16ahci: combine identical clauses in port writehw/ide/ahci.c+0 -40 replies
6/16ahci: modify ahci_port_write to use register numbershw/ide/ahci.c+17 -150 replies
7/16ahci: make port write traces more descriptivehw/ide/ahci.c hw/ide/trace-events+9 -20 replies
8/16ahci: delete old port register address definitionshw/ide/ahci_internal.h+0 -180 replies
9/16ahci: add host register enumerationhw/ide/ahci.c hw/ide/ahci_internal.h+30 -00 replies
10/16ahci: fix host register max addresshw/ide/ahci_internal.h+1 -20 replies
11/16ahci: modify ahci_mem_read_32 to work on register numbershw/ide/ahci.c+11 -60 replies
12/16ahci: make mem_read_32 traces more descriptivehw/ide/ahci.c hw/ide/trace-events+8 -20 replies
13/16ahci: fix spacing damage on ahci_mem_writehw/ide/ahci.c+23 -240 replies
14/16ahci: adjust ahci_mem_write to work on registershw/ide/ahci.c+9 -60 replies
15/16ahci: delete old host register address definitionshw/ide/ahci_internal.h+0 -60 replies
16/16ahci: make ahci_mem_write traces more descriptivehw/ide/ahci.c hw/ide/trace-events+15 -20 replies

Reviews trailers per patch

None of the 16 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPhilippe Mathieu-Daudé
SeriesR-b
1/16
2/16
3/16
4/16
5/16
6/16
7/16
8/16
9/16
10/16
11/16
12/16
13/16
14/16
15/16
16/16

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 00/16] AHCI: tracing improvements

This set just adds register names so that the read/write traces make more sense on their own without having to memorize register offsets. It also splits read/write traces into supported/unsupported subsets, so you can just monitor for things that QEMU is likely doing wrong.

v2:
- Added qemu_log_mask(LOG_UNIMP, ...) statements in addition to traces for writes to unknown/unsupported registers. (Philippe)

John Snow (16):
ahci: add port register enumeration
ahci: modify ahci_port_read to use register numbers
ahci: make port read traces more descriptive
ahci: fix spacing damage on ahci_port_write
ahci: combine identical clauses in port write
ahci: modify ahci_port_write to use register numbers
ahci: make port write traces more descriptive
ahci: delete old port register address definitions
ahci: add host register enumeration
ahci: fix host register max address
ahci: modify ahci_mem_read_32 to work on register numbers
ahci: make mem_read_32 traces more descriptive
ahci: fix spacing damage on ahci_mem_write
ahci: adjust ahci_mem_write to work on registers
ahci: delete old host register address definitions
ahci: make ahci_mem_write traces more descriptive

 hw/ide/ahci.c          | 314 ++++++++++++++++++++++++++++++-------------------
 hw/ide/ahci_internal.h |  63 ++++++----
 hw/ide/trace-events    |  13 +-
 3 files changed, 241 insertions(+), 149 deletions(-)
Signature · 1 line
2.14.3