Skip to content

Use __aligned_u64 in UAPI fields

Eugene Syromiatnikov lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2bpf: fix alignment of netns_dev/netns_ino fields in bpf_{map,prog}_infoinclude/uapi/linux/bpf.h tools/include/uapi/linux/bpf.h+8 -86 replies
2/2bpf: enforce usage of __aligned_u64 in the UAPI headerinclude/uapi/linux/bpf.h tools/include/uapi/linux/bpf.h+22 -222 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchDmitry V. Levin
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH bpf 0/2] Use __aligned_u64 in UAPI fields

Hello.

It was discovered during strace development that struct bpf_map_info and struct bpf_prog_info now have different layouts of i386/compat and x86_64. Since it's already broken and bpf syscall has no separate compat (as far as I can see), and the affecting change was introduced recently (in Linux 4.16), it's proposed to change the layout of these structures on 32-bit architectures by using __aligned_u64.

In order to somewhat future-proof from this problem in future, an approach similar to the one implemented in RDMA subsystem recently is proposed: use __aligned_u64 consistently throughout the UAPI header.

Eugene Syromiatnikov (2):
bpf: fix alignment of netns_dev/netns_ino fields in

    bpf_{map,prog}_info

bpf: enforce usage of __aligned_u64 in the UAPI header

 include/uapi/linux/bpf.h       | 30 +++++++++++++++---------------
 tools/include/uapi/linux/bpf.h | 30 +++++++++++++++---------------
 2 files changed, 30 insertions(+), 30 deletions(-)
Signature · 1 line
2.1.4