Skip to content

Runtime PM support for wlcore

Tony Lindgren linux-omap linux-wireless 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 14 repliesIn review

Changes since v2 from the cover letter

- Add fix "wclore: Fix timout errors after recovery" that is not needed before runtime PM conversion

- Add fix from Eyal for "wlcore: Use generic runtime pm calls for wowlan elp configuration" that is also not needed before runtime PM conversion

- Return early from wlcore_runtime_resume() on ELP timeout to avoid clearing WL1271_FLAG_IN_ELP bit

- Tag as RFT as we still need to do more testing and add runtime PM autosuspend support before merging

- Drop "wlcore: sdio: Warn about runtime PM suspend errors" that should no longer be needed

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6wlcore: Add missing PM call for wlcore_cmd_wait_for_event_or_timeout()drivers/net/wireless/ti/wlcore/cmd.c+6 -01 reply
2/6wlcore: Make sure PM calls are paireddrivers/net/wireless/ti/wlcore/main.c+8 -20 replies
3/6wlcore: Add support for runtime PMdrivers/net/wireless/ti/wl18xx/debugfs.c drivers/net/wireless/ti/wlcore/acx.c drivers/net/wireless/ti/wlcore/cmd.c +11 more+416 -33810 replies
4/6wlcore: Fix misplaced PM call for scan_complete_work()drivers/net/wireless/ti/wlcore/scan.c+0 -10 replies
5/6wclore: Fix timout errors after recoverydrivers/net/wireless/ti/wlcore/main.c+1 -10 replies
6/6wlcore: Use generic runtime pm calls for wowlan elp configurationdrivers/net/wireless/ti/wlcore/main.c+13 -382 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFTv3 0/6] Runtime PM support for wlcore

Hi all,

Here's the third version of wlcore runtime PM changes. Things seem to be working for me just fine now after few fixes listed below. Please do test again though, and then I'll post this series and one more patch after v4.18-rc1 to enable runtime PM autosuspend support. So hopefully we can have these merged early on for v4.19.

For testing, please make sure you have also applied patch "[PATCHv2] wlcore: sdio: Fix flakey SDIO runtime PM handling" to avoid bogus errors.

Regards,

Tony

Changes since v2:

- Add fix "wclore: Fix timout errors after recovery" that is not needed before runtime PM conversion

- Add fix from Eyal for "wlcore: Use generic runtime pm calls for wowlan elp configuration" that is also not needed before runtime PM conversion

- Return early from wlcore_runtime_resume() on ELP timeout to avoid clearing WL1271_FLAG_IN_ELP bit

- Tag as RFT as we still need to do more testing and add runtime PM autosuspend support before merging

- Drop "wlcore: sdio: Warn about runtime PM suspend errors" that should no longer be needed

Changes since v1:

- Fix issues reported by Eyal for recovery

- Add few patches for enable/disable issues found when using runtime PM

- Remove unused ps.h includes

Eyal Reizer (1):
wlcore: Use generic runtime pm calls for wowlan elp configuration

Tony Lindgren (5):
wlcore: Add missing PM call for wlcore_cmd_wait_for_event_or_timeout()
wlcore: Make sure PM calls are paired
wlcore: Add support for runtime PM
wlcore: Fix misplaced PM call for scan_complete_work()
wclore: Fix timout errors after recovery

 drivers/net/wireless/ti/wl18xx/debugfs.c    |  26 +-
 drivers/net/wireless/ti/wlcore/acx.c        |   1 -
 drivers/net/wireless/ti/wlcore/cmd.c        |   9 +
 drivers/net/wireless/ti/wlcore/debugfs.c    |  79 ++--
 drivers/net/wireless/ti/wlcore/main.c       | 464 +++++++++++++-------
 drivers/net/wireless/ti/wlcore/ps.c         | 146 ------
 drivers/net/wireless/ti/wlcore/ps.h         |   3 -
 drivers/net/wireless/ti/wlcore/scan.c       |  12 +-
 drivers/net/wireless/ti/wlcore/sysfs.c      |  12 +-
 drivers/net/wireless/ti/wlcore/testmode.c   |  18 +-
 drivers/net/wireless/ti/wlcore/tx.c         |   9 +-
 drivers/net/wireless/ti/wlcore/vendor_cmd.c |  27 +-
 drivers/net/wireless/ti/wlcore/wlcore.h     |   1 -
 drivers/net/wireless/ti/wlcore/wlcore_i.h   |   1 -
 14 files changed, 436 insertions(+), 372 deletions(-)
Signature · 1 line
2.17.0