Skip to content

lockdown/module: make module name available for module_sig_check()

Jessica Yu lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3module: make it clear when we're handling the module copy in info->hdrkernel/module.c+21 -210 replies
2/3module: setup load info before module_sig_check()kernel/module.c+43 -340 replies
3/3modsign: print module name along with error messagekernel/module.c+1 -11 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] lockdown/module: make module name available for module_sig_check()

Hi David,

The changes here involve cleaning up load_module() (patches 1 and 2) in preparation for patch 3. The general idea is to do some preliminary module section parsing and set up load info convenience variables earlier so that we could log the module name during the module signature verification check if it fails. Right now the module name is not logged if signature verification fails, and it would be helpful to know which module failed loading.

Currently, all patches are based on the lockdown tree:

http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=lockdown

But my plan is probably to take patches 1 and 2 through the modules-next tree as they are generic cleanups, but I wanted to give you a heads up for patch 3, which should probably be taken through the lockdown tree.

Thanks!

Jessica

---
Jessica Yu (3):
module: make it clear when we're handling the module copy in info->hdr
module: setup load info before module_sig_check()
modsign: print module name along with error message

 kernel/module.c | 105 ++++++++++++++++++++++++++++++--------------------------
 1 file changed, 57 insertions(+), 48 deletions(-)
Signature · 1 line
2.16.3