Tegra20 External Memory Controller driver
Status from this message: Applied to for-4.21/dt-bindings, thanks.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v6 Latest8 patches 10 repliesApplied
- v58 patches 3 repliesSuperseded
- v48 patches 1 replySuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v3 | 8 patches | 4 replies | Superseded | |
| v2 | 5 patches | 12 replies | Superseded | |
| v1 | 4 patches | 2 replies | Superseded |
Changes in v6 from the cover letter
- Driver now handles "refresh request overflow" interrupt by reporting error message.
- EMC rate is set during driver initialization to ensure that clock divider is in a proper state.
Patches in v6 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | dt: bindings: tegra20-emc: Document interrupt propertyDocumentation/ | +2 | 1 reply | |
| 2/8 | dt: bindings: tegra20-emc: Document clock propertyDocumentation/ | +2 | 1 reply | |
| 3/8 | dt: bindings: Move tegra20-emc binding to memory-controllers directoryDocumentation/ | +0 | 1 reply | |
| 4/8 | ARM: dts: tegra20: Add interrupt entry to External Memory Controllerarch/ | +1 | 2 replies | |
| 5/8 | ARM: dts: tegra20: Add clock entry to External Memory Controllerarch/ | +1 | 1 reply | |
| 6/8 | clk: tegra20: Turn EMC clock gate into dividerdrivers/ | +26 | 1 reply | |
| 7/8 | clk: tegra20: Check whether direct PLLM sourcing is turned off for EMCdrivers/ | +10 | 1 reply | |
| 8/8 | memory: tegra: Introduce Tegra20 EMC driverdrivers/ drivers/ drivers/ | +602 | 2 replies |
Reviews trailers per patch
7 of 8 patches have a Reviewed-by or Acked-by.
| Patch | Rob Herring | Peter De Schrijver | Stephen Boyd |
|---|---|---|---|
| 1/8 | A-b | A-b | |
| 2/8 | A-b | ||
| 3/8 | A-b | ||
| 4/8 | A-b | ||
| 5/8 | |||
| 6/8 | A-b | A-b | |
| 7/8 | A-b | A-b | |
| 8/8 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v6 0/8] Tegra20 External Memory Controller driver
Changelog:
v6:
- Driver now handles "refresh request overflow" interrupt by reporting error message.
- EMC rate is set during driver initialization to ensure that clock divider is in a proper state.
v5:
- Fixed wrong EMC clock divider type in the "Turn EMC clock gate into divider" patch. It is a Tegra's fractional 7.1 divider and not a simple integer divider. Peter, please take a look at the change.
v4:
- Fixed "bad of_node_put()" error which was revealed by enabling some extra kernel debug config options.
- The "emc-table" DT nodes are now parsed starting from the "emc" node instead of the DT root.
- Adjusted code comment in the "Turn EMC clock gate into divider" patch as was suggested by Stephen Boyd to the v3.
v3:
- Handle "nvidia,use-ram-code" DT property, its handling was missed in the previous versions.
- Honor "emc-tables" DT node naming which is explicitly specified in the DT binding, also was missed in the previous versions.
- Two new DT binding patches: one adds the EMC clock property, other relocates the binding doc file to the appropriate directory. One new patch that adds EMC clock property to the DTS file.
- Addressed v2 review comments from Thierry Reding. Driver does not preserve backwards compatibility with older device tree binding.
- The PLL_M and PLL_P clocks are kept internal to the driver because after some more considering I couldn't find a really good reason why these clocks should be in the device tree.
- Some minor cleanups and fixes in the drivers code.
v2:
- Minor code cleanups like consistent use of writel_relaxed instead of non-relaxed version, reworded error messages, etc.
- Factored out use_pllm_ud bit checking into a standalone patch for consistency.
Dmitry Osipenko (8):
dt: bindings: tegra20-emc: Document interrupt property
dt: bindings: tegra20-emc: Document clock property
dt: bindings: Move tegra20-emc binding to memory-controllers directory
ARM: dts: tegra20: Add interrupt entry to External Memory Controller
ARM: dts: tegra20: Add clock entry to External Memory Controller
clk: tegra20: Turn EMC clock gate into divider
clk: tegra20: Check whether direct PLLM sourcing is turned off for EMC
memory: tegra: Introduce Tegra20 EMC driver
.../nvidia,tegra20-emc.txt | 4 +
arch/arm/boot/dts/tegra20.dtsi | 2 +
drivers/clk/tegra/clk-tegra20.c | 46 +-
drivers/memory/tegra/Kconfig | 10 +
drivers/memory/tegra/Makefile | 1 +
drivers/memory/tegra/tegra20-emc.c | 591 ++++++++++++++++++
6 files changed, 644 insertions(+), 10 deletions(-)
rename Documentation/devicetree/bindings/{arm/tegra => memory-controllers}/nvidia,tegra20-emc.txt (95%)
create mode 100644 drivers/memory/tegra/tegra20-emc.cSignature · 1 line
2.19.0