Skip to content

ahci: fix completion race condition

John Snow qemu-devel 1 version Applied

Status from this message: Thanks, applied to my IDE tree:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 12 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3ahci: trim signatures on raise/lowerhw/ide/ahci.c+4 -43 replies
2/3ahci: fix PxCI register racehw/ide/ahci.c+6 -72 replies
3/3ahci: don't schedule unnecessary BHhw/ide/ahci.c+1 -21 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchStefan HajnocziJeff CodyBruce Rogers
SeriesR-b
1/3R-b
2/3R-b T-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/3] ahci: fix completion race condition

Commit d759c951f changed the main thread lock release/reacquisition, and in so doing apparently jostled loose a race condition in the AHCI code.

Patch 2 should be sufficient to fix this, and patches 1 and 3 are just little trivial fixes.

This might be sufficient to fix the bug as reported at
https://bugs.launchpad.net/qemu/+bug/1769189
but the nature of the timing changes make it difficult to confirm, so I am posting this patchset for the reporters to help test.

John Snow (3):
ahci: trim signatures on raise/lower
ahci: fix PxCI register race
ahci: don't schedule unnecessary BH

 hw/ide/ahci.c | 24 +++++++++++-------------
 1 file changed, 11 insertions(+), 13 deletions(-)
Signature · 1 line
2.14.3