monitor: enable OOB by default
Status from this message: Queued except for PATCH 2/6. Thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v9 Latest6 patches 11 repliesApplied
- v86 patches 3 repliesSuperseded
- v77 patches 20 repliesSuperseded
Earlier versions · 5
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v6 | 13 patches | 15 replies | Superseded | |
| v5 | 7 patches | 40 replies | Superseded | |
| v4 | 7 patches | 20 replies | Superseded | |
| v3 | 6 patches | 9 replies | Superseded | |
| v2 RFC | 4 patches | 12 replies | Superseded |
Changes in v9 from the cover letter
- add r-bs
- release the qmp queue lock before resume [Marc-Andre]
Patches in v9 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | monitor: Suspend monitor instead dropping commandsdocs/ include/ monitor.c +1 more | +28 | 1 reply | |
| 2/6 | monitor: resume the monitor earlier if neededmonitor.c | +6 | 3 replies | |
| 3/6 | monitor: remove "x-oob", turn oob on by defaultinclude/ monitor.c tests/ +2 more | +8 | 0 replies | |
| 4/6 | Revert "tests: Add parameter to qtest_init_without_qmp_handshake"tests/ tests/ tests/ | +7 | 0 replies | |
| 5/6 | tests: add oob functional test for test-qmp-cmdstests/ | +16 | 0 replies | |
| 6/6 | tests: qmp-test: add queue full testtests/ | +26 | 0 replies |
Reviews trailers per patch
5 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Marc-André Lureau | Markus Armbruster |
|---|---|---|
| 1/6 | R-b | |
| 2/6 | ||
| 3/6 | R-b | R-b |
| 4/6 | R-b | R-b |
| 5/6 | R-b | |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v9 0/6] monitor: enable OOB by default
Based-on: <[email protected]>
Based-on: <[email protected]>
(this series is based on Markus's monitor-next tree)
v9:
- add r-bs
- release the qmp queue lock before resume [Marc-Andre]
v8:
- remove patch 1 & 2 since already in the QAPI pull
- squash patch 3 & 4, use Markus's version of commit message (with some of my additions), make sure popping and reading queue length is in the same critical section [Markus]
- add one patch to cover test for queue full [Markus]
- add one patch to resume the monitor earlier when queue not full [Markus]
v7:
- use Markus's commit message for patch "qapi: Drop qapi_event_send_FOO()'s Error ** argument" [Markus]
- update commit message for "qapi: remove COMMAND_DROPPED event" since QEMU 3.0 is released [Eric/Dave]
- rebase to Markus's monitor-next tree:
http://repo.or.cz/qemu/armbru.git/shortlog/refs/heads/monitor-next
the patch "monitor: suspend monitor instead of send CMD_DROP" re-written since people prefer to drop need_resume flag so now I hand-made it. Dropped a few patches since not appliable any more.
Please review. Thanks,
Peter Xu (6):
monitor: Suspend monitor instead dropping commands
monitor: resume the monitor earlier if needed
monitor: remove "x-oob", turn oob on by default
Revert "tests: Add parameter to qtest_init_without_qmp_handshake"
tests: add oob functional test for test-qmp-cmds
tests: qmp-test: add queue full test
docs/interop/qmp-spec.txt | 5 ++- include/monitor/monitor.h | 3 +- monitor.c | 82 ++++++++++++++++----------------------- qapi/misc.json | 40 ------------------- tests/libqtest.c | 10 ++--- tests/libqtest.h | 4 +- tests/qmp-test.c | 32 +++++++++++++-- tests/test-qmp-cmds.c | 16 ++++++++ vl.c | 5 --- 9 files changed, 89 insertions(+), 108 deletions(-)
Signature · 1 line
2.17.1