Skip to content

Avoid retrying on serial_xmit with EPIPE

Sergio Lopez qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 14 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3io: Implement QIO_CHANNEL_ERR_BROKENinclude/io/channel.h io/channel-file.c+4 -01 reply
2/3chardev: On QIO_CHANNEL_ERR_BROKEN set errno to EPIPEchardev/char-io.c+3 -03 replies
3/3hw/char/serial: Don't retry on serial_xmit if errno == EPIPEhw/char/serial.c+1 -010 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchMarc-André Lureau
1/3
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/3] Avoid retrying on serial_xmit with EPIPE

EPIPE is not a recoverable error, so retrying on serial_xmit is a waste of CPU cycles, and can potentially comprosie the Guest OS stability if both the vCPU and the emulator thread are pinned to the same pCPU, with the first one actively polling the serial device and barely giving time to the second to make any actual progress.

Sergio Lopez (3):
io: Implement QIO_CHANNEL_ERR_BROKEN
chardev: On QIO_CHANNEL_ERR_BROKEN set errno to EPIPE hw/char/serial: Don't retry on serial_xmit if errno == EPIPE

 chardev/char-io.c    | 3 +++
 hw/char/serial.c     | 1 +
 include/io/channel.h | 1 +
 io/channel-file.c    | 3 +++
 4 files changed, 8 insertions(+)
Signature · 1 line
1.8.3.1