Skip to content

devlink: Add extack messages for reload and port split/unsplit

[email protected] netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesIn review
  2. v13 patches 10 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3devlink: Add extack to reload and port_{un,}split operationsdrivers/net/ethernet/mellanox/mlxsw/core.c drivers/net/ethernet/netronome/nfp/nfp_devlink.c drivers/net/netdevsim/devlink.c +2 more+25 -170 replies
2/3netdevsim: Add extack error message for devlink reloaddrivers/net/netdevsim/devlink.c drivers/net/netdevsim/fib.c drivers/net/netdevsim/netdevsim.h+10 -60 replies
3/3mlxsw: Add extack messages for port_{un,}split failuresdrivers/net/ethernet/mellanox/mlxsw/core.c drivers/net/ethernet/mellanox/mlxsw/core.h drivers/net/ethernet/mellanox/mlxsw/spectrum.c+25 -91 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchJiri PirkoJakub KicinskiIdo Schimmel
1/3A-b
2/3A-b
3/3A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 net-next 0/3] devlink: Add extack messages for reload and port split/unsplit

From: David Ahern <[email protected]>

Patch 1 adds extack arg to reload, port_split and port_unsplit devlink operations.

Patch 2 adds extack messages for reload operation in netdevsim.

Patch 3 adds extack messages to port split/unsplit in mlxsw driver.

v2
- make the extack messages align with existing dev_err

David Ahern (3):
devlink: Add extack to reload and port_{un,}split operations
netdevsim: Add extack error message for devlink reload
mlxsw: Add extack messages for port_{un,}split failures

 drivers/net/ethernet/mellanox/mlxsw/core.c       | 23 ++++++++++++++++-------
 drivers/net/ethernet/mellanox/mlxsw/core.h       |  5 +++--
 drivers/net/ethernet/mellanox/mlxsw/spectrum.c   | 15 ++++++++++++---
 drivers/net/ethernet/netronome/nfp/nfp_devlink.c |  5 +++--
 drivers/net/netdevsim/devlink.c                  |  7 ++++---
 drivers/net/netdevsim/fib.c                      |  9 ++++++---
 drivers/net/netdevsim/netdevsim.h                |  3 ++-
 include/net/devlink.h                            |  7 ++++---
 net/core/devlink.c                               | 18 ++++++++++--------
 9 files changed, 60 insertions(+), 32 deletions(-)
Signature · 1 line
2.11.0