Skip to content

block dirty bitmaps: support libvirt API

John Snow qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 4 repliesIn review
  2. v15 patches 6 repliesSuperseded

v4 from the cover letter

- Reinstated Vladimir's authorship credit on all patches
- Switched 2.12 to 3.0
- Edited doc to clarify failure mode for merge (Jeff)
- Removed !bs check where applicable (Jeff)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmapblock/dirty-bitmap.c+4 -20 replies
2/5qapi: add x-block-dirty-bitmap-enable/disableblockdev.c qapi/block-core.json+84 -01 reply
3/5qmp: transaction support for x-block-dirty-bitmap-enable/disableblockdev.c qapi/transaction.json+84 -11 reply
4/5qapi: add x-block-dirty-bitmap-mergeblock/dirty-bitmap.c blockdev.c include/block/dirty-bitmap.h +1 more+88 -11 reply
5/5qapi: add disabled parameter to block-dirty-bitmap-addblockdev.c qapi/block-core.json+15 -10 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchJeff Cody
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/5] block dirty bitmaps: support libvirt API

This is largely the same series that Vladimir sent in January, but at the time I was unsure of if we'd want these commands or not in QEMU.

After discussing with Virtuozzo their plans for a checkpoint-like API implemented primarily in libvirt, I agree that these commands are at least tentatively useful.

Eric Blake is currently writing a counter-proposal and demo API to show to Virtuozzo on libvirt's development list. Check in these QMP commands with the experimental prefix 'x-' for now so that it can be used for prototyping.

Once the design for the libvirt API looks reasonably final I will remove the 'x-' prefixes, or, if we wind up not using these particular commands I will delete them entirely.

v4:
- Reinstated Vladimir's authorship credit on all patches
- Switched 2.12 to 3.0
- Edited doc to clarify failure mode for merge (Jeff)
- Removed !bs check where applicable (Jeff)

v3:
- Drop patch one (already merged)
- Minor phrasing adjustments to documentation
- Removed &state->bs argument to bitmap lookup for enable/disable
- Added x- prefix to all three commands and to add's new argument.

Vladimir's original cover letter is below:

There are three qmp commands, needed to implement external backup API.

Using these three commands, client may do all needed bitmap management by hand:

on backup start we need to do a transaction:
{disable old bitmap, create new bitmap}

on backup success:
drop old bitmap

on backup fail:
enable old bitmap
merge new bitmap to old bitmap
drop new bitmap

Vladimir Sementsov-Ogievskiy (5):
block/dirty-bitmap: add lock to bdrv_enable/disable_dirty_bitmap
qapi: add x-block-dirty-bitmap-enable/disable
qmp: transaction support for x-block-dirty-bitmap-enable/disable
qapi: add x-block-dirty-bitmap-merge
qapi: add disabled parameter to block-dirty-bitmap-add

 block/dirty-bitmap.c         |  24 ++++++-
 blockdev.c                   | 163 ++++++++++++++++++++++++++++++++++++++++++-
 include/block/dirty-bitmap.h |   3 +-
 qapi/block-core.json         |  86 ++++++++++++++++++++++-
 qapi/transaction.json        |   4 ++
 5 files changed, 275 insertions(+), 5 deletions(-)
Signature · 1 line
2.14.3