Skip to content

refspec: refactor & fix free() behavior

Ævar Arnfjörð Bjarmason git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3refspec: s/refspec_item_init/&_or_die/gbuiltin/clone.c builtin/pull.c refspec.c +1 more+7 -50 replies
2/3refspec: add back a refspec_item_init() functionrefspec.c refspec.h+9 -30 replies
3/3refspec: initalize `refspec_item` in `valid_fetch_refspec()`refspec.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] refspec: refactor & fix free() behavior

Since Martin & Brandon both liked this direction I've fixed it up.

Martin: I didn't want to be the author of the actual fix for the bug you found, so I rewrote your commit in 3/3. The diff is different, and I slightly modified the 3rd paragraph of the commit message & added my sign-off, but otherwise it's the same.

Martin Ågren (1):
refspec: initalize refspec_item in valid_fetch_refspec()

Ævar Arnfjörð Bjarmason (2):
refspec: s/refspec_item_init/&_or_die/g
refspec: add back a refspec_item_init() function

 builtin/clone.c |  2 +-
 builtin/pull.c  |  2 +-
 refspec.c       | 13 +++++++++----
 refspec.h       |  5 ++++-
 4 files changed, 15 insertions(+), 7 deletions(-)
Signature · 1 line
2.17.0.290.gded63e768a