Skip to content

glib: update the min required version

Daniel P. Berrangé qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 6 repliesIn review
  2. v23 patches 18 repliesSuperseded

Changes in v3 from the cover letter

- Use #pragma instead of _Pragma
- Move dockerfile deletion to earlier patch
- Add missing osdep.h include
- Reorder patches to preserve bisectability

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3util: remove redundant include of glib.h and add osdep.hinclude/qemu/iova-tree.h util/iova-tree.c+1 -23 replies
2/3glib: bump min required glib library version to 2.40configure crypto/hash-glib.c crypto/hmac-glib.c +10 more+11 -4670 replies
3/3glib: enforce the minimum required version and warn about old APIsinclude/glib-compat.h tests/test-qga.c+68 -21 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéThomas HuthEric BlakePeter Xu
1/3R-b R-b R-b R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [Qemu-devel] [PATCH v3 0/3] glib: update the min required version

The previous patch to bump glib to 2.42 hit problems with Peter's build environment for testing merge:

https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg02557.html

This posting drops back to 2.40, which allows Ubuntu 14.04 from GLibC compile farm to be supported.

It does NOT try to go back to 2.34, because it is hoped that the mxe.cc Debian packages will be suitable for Peter to test Windows cross-compile. Alternatively the docker environments provided in tree can be used for mingw build testing on any host able to run docker.

I also dropped some more GLIB_CHECK_VERSION checks that are redundant given the new min version.

Changed in v3:

- Use #pragma instead of _Pragma
- Move dockerfile deletion to earlier patch
- Add missing osdep.h include
- Reorder patches to preserve bisectability

Daniel P. Berrangé (3):
util: remove redundant include of glib.h and add osdep.h
glib: bump min required glib library version to 2.40
glib: enforce the minimum required version and warn about old APIs

 configure                                |   6 +-
 crypto/hash-glib.c                       |   4 -
 crypto/hmac-glib.c                       |  36 ---
 include/glib-compat.h                    | 373 ++++-------------------
 include/qemu/iova-tree.h                 |   1 -
 qga/commands.c                           |  11 +-
 tests/docker/dockerfiles/centos6.docker  |  30 --
 tests/docker/dockerfiles/min-glib.docker |   8 -
 tests/ivshmem-test.c                     |   6 -
 tests/test-qga.c                         |   2 -
 tests/test-qmp-event.c                   |   8 +-
 tests/tpm-emu.h                          |   4 +-
 tests/vhost-user-test.c                  |  26 +-
 trace/simple.c                           |   6 +-
 util/iova-tree.c                         |   2 +-
 util/osdep.c                             |  14 -
 16 files changed, 73 insertions(+), 464 deletions(-)
 delete mode 100644 tests/docker/dockerfiles/centos6.docker
 delete mode 100644 tests/docker/dockerfiles/min-glib.docker
Signature · 1 line
2.17.0