atapi: change unlimited recursion to while loop
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | libqos/ahci: track sector sizetests/ | +6 | 1 reply | |
| 2/7 | ahci: move PIO Setup FIS before transfer, fix it for ATAPI commandshw/ tests/ tests/ | +28 | 0 replies | |
| 3/7 | ide: push end_transfer_func out of start_transfer callback, rename callbackhw/ hw/ hw/ +1 more | +13 | 0 replies | |
| 4/7 | ide: call ide_cmd_done from ide_transfer_stophw/ | +4 | 1 reply | |
| 5/7 | ide: make ide_transfer_stop idempotenthw/ | +4 | 1 reply | |
| 6/7 | atapi: call ide_set_irq before ide_transfer_starthw/ | +6 | 0 replies | |
| 7/7 | ide: introduce ide_transfer_start_norecursehw/ hw/ include/ | +37 | 0 replies |
Reviews trailers per patch
3 of 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Philippe Mathieu-Daudé | John Snow |
|---|---|---|
| Series | R-b | |
| 1/7 | R-b | |
| 2/7 | ||
| 3/7 | ||
| 4/7 | R-b | |
| 5/7 | R-b | |
| 6/7 | ||
| 7/7 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH 0/7] atapi: change unlimited recursion to while loop
Real hardware doesn't have an unlimited stack, so the unlimited recursion in the ATAPI code smells a bit. In fact, the call to ide_transfer_start easily becomes a tail call with a small change to the code (patch 5); however, we also need to turn the call back to ide_atapi_cmd_reply_end into another tail call before turning the (double) tail recursion into a while loop.
In particular, patch 1 ensures that the call to the end_transfer_func is the last thing in ide_transfer_start. To do so, it moves the write of the PIO Setup FIS before the PIO transfer, which actually makes sense:
the FIS is sent by the device to inform the AHCI about the transfer, so it cannot come after! This is the main change from the RFC, and it simplifies the rest of the series (the RFC had to introduce an "end_transfer" callback just for writing the PIO Setup FIS).
I tested this manually with READ CD commands sent through sg_raw, and the existing AHCI tests still pass.
v2: reworked PIO Setup FIS based on spec reading, adjusted tests.
John Snow (2):
libqos/ahci: track sector size
ahci: move PIO Setup FIS before transfer, fix it for ATAPI commands
Paolo Bonzini (5):
ide: push end_transfer_func out of start_transfer callback, rename
callback
ide: call ide_cmd_done from ide_transfer_stop
ide: make ide_transfer_stop idempotent
atapi: call ide_set_irq before ide_transfer_start
ide: introduce ide_transfer_start_norecurse
hw/ide/ahci.c | 31 ++++++++++++------------------- hw/ide/atapi.c | 44 ++++++++++++++++++++++++-------------------- hw/ide/core.c | 39 ++++++++++++++++++++------------------- hw/ide/trace-events | 2 +- include/hw/ide/internal.h | 4 +++- tests/libqos/ahci.c | 45 +++++++++++++++++++++++++++------------------ tests/libqos/ahci.h | 3 +-- 7 files changed, 88 insertions(+), 80 deletions(-)
Signature · 1 line
2.14.3