Skip to content

xfs: fix buffer delwri queue state race

Brian Foster linux-xfs 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest posting 2/22 patches 3 repliesIn review
  2. v3 posting 1/21 of 2 patches 2 repliesSuperseded
  3. v22 patches 11 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches4 repliesSuperseded

Changes in v3 from the cover letter

- Leave tracepoint in __xfs_buf_submit and kill trace_xfs_buf_submit_wait().
- Comment tweaks.
v2: https://marc.info/?l=linux-xfs&m=152888792024447&w=2
- Implement sync buffer I/O for sync delwri queues instead of buffer wait list stealing.
v1: https://marc.info/?l=linux-xfs&m=152837528705511&w=2

Patches in v3 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2xfs: refactor buffer submission into a common helperfs/xfs/xfs_buf.c fs/xfs/xfs_trace.h+37 -491 reply
2/2xfs: use sync buffer I/O for sync delwri queue submissionfs/xfs/xfs_buf.c+41 -373 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchDave ChinnerChristoph HellwigDarrick J. Wong
1/2Designed-by R-b R-b
2/2Designed-by Designed-by

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/2] xfs: fix buffer delwri queue state race

I'll post the xfs_buf_submit[_wait]() refactoring patch separately after waiting for some feedback in the previous thread and/or doing some testing. It really has nothing to do with fixing this problem, anyways.

Brian

v3:
- Leave tracepoint in __xfs_buf_submit and kill trace_xfs_buf_submit_wait().
- Comment tweaks.
v2: https://marc.info/?l=linux-xfs&m=152888792024447&w=2
- Implement sync buffer I/O for sync delwri queues instead of buffer wait list stealing.
v1: https://marc.info/?l=linux-xfs&m=152837528705511&w=2

Brian Foster (2):
xfs: refactor buffer submission into a common helper
xfs: use sync buffer I/O for sync delwri queue submission

 fs/xfs/xfs_buf.c   | 163 ++++++++++++++++++++++-----------------------
 fs/xfs/xfs_trace.h |   1 -
 2 files changed, 78 insertions(+), 86 deletions(-)
Signature · 1 line
2.17.1