Skip to content

memory: fix alignment checks/asserts

David Hildenbrand qemu-devel 1 version Applied

Status from this message: Queued, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2memory-device: turn alignment assert into checkhw/mem/memory-device.c+7 -11 reply
2/2exec: check that alignment is a power of twoexec.c+4 -01 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMichael S. TsirkinIgor Mammedov
SeriesR-b
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH v1 0/2] memory: fix alignment checks/asserts

We can currently hit two asserts. Let's fix those.

Patch nr. 1 is a result from:
"[PATCH v4 00/14] MemoryDevice: use multi stage hotplug handlers"

We treat right now any alignment > 1GB as a violation, as it would fragment guest memory heavily. Turn the assert into a check.

Also, we run into an assert when using alignments that are not a power of two.

David Hildenbrand (2):
memory-device: turn alignment assert into check
exec: check that alignment is a power of two

 exec.c                 | 4 ++++
 hw/mem/memory-device.c | 8 +++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)
Signature · 1 line
2.17.0