Skip to content

spapr: machine hotplug handler cleanups

David Hildenbrand qemu-devel 2 versions – Applied

Status from this message: Applied to ppc-for-3.0, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 3 repliesApplied
  2. v18 patches 43 repliesSuperseded

Changes in v2 from the cover letter

- dropped the three "local_err" patches
- tweaked some patch descriptions
- Split "spapr: move all DIMM checks into spapr_memory_plug" up -- Move the memory hotplug check into the pre_plug handler
- Use &error_abort instead of NULL

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/6spapr: no need to verify the nodehw/ppc/spapr.c+2 -80 replies
2/6spapr: move lookup of the node into spapr_memory_plug()hw/ppc/spapr.c+5 -71 reply
3/6spapr: move memory hotplug support check into spapr_memory_pre_plug()hw/ppc/spapr.c+6 -71 reply
4/6spapr: introduce machine unplug handlerhw/ppc/spapr.c+6 -00 replies
5/6spapr: handle pc-dimm unplug via hotplug handler chainhw/ppc/spapr.c+15 -30 replies
6/6spapr: handle cpu core unplug via hotplug handler chainhw/ppc/spapr.c+11 -10 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchDavid GibsonGreg KurzIgor Mammedov
1/6A-b R-b
2/6R-b
3/6R-b
4/6A-b R-b
5/6A-b R-b R-b
6/6A-b R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/6] spapr: machine hotplug handler cleanups

I'll be messing with machine hotplug handlers of pc/spapr/s390x in the context of
[PATCH v4 00/14] MemoryDevice: use multi stage hotplug handlers

So this is a spin-off of the cleanup patches in the context of hotplug handlers.

v1 -> v2:
- dropped the three "local_err" patches
- tweaked some patch descriptions
- Split "spapr: move all DIMM checks into spapr_memory_plug" up -- Move the memory hotplug check into the pre_plug handler
- Use &error_abort instead of NULL

David Hildenbrand (6):
spapr: no need to verify the node
spapr: move lookup of the node into spapr_memory_plug()
spapr: move memory hotplug support check into spapr_memory_pre_plug()
spapr: introduce machine unplug handler
spapr: handle pc-dimm unplug via hotplug handler chain
spapr: handle cpu core unplug via hotplug handler chain

 hw/ppc/spapr.c | 67 ++++++++++++++++++++++++++++++++------------------
 1 file changed, 43 insertions(+), 24 deletions(-)
Signature · 1 line
2.17.0