Skip to content

blktests: NVMeOF new testcases for file and bdev ns

Omar Sandoval linux-nvme 2 versions – New

Get series with b4
b4 am 20180625190429.GA1218@vader

Versions newest first · linked by author and title

  1. v2 Latest posting 2/20 of 14 patches 0 repliesNew
  2. v2 posting 1/21 of 14 patches 0 repliesSuperseded

Patches in v2 posting 2/2 No applies recorded yet

None of the 14 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH V2 00/14] blktests: NVMeOF new testcases for file and bdev ns
Quoted 32 lines · Omar Sandoval
Quoted 4 lines · Chaitanya Kulkarni

Thanks, Johannes for the review comments.

Omar, let me know if you find any issues, otherwise, we can merge this series.

I was able to fix the flush tests by replacing

nvme flush /dev/"${nvmedev}n1"

With

nvme flush /dev/"${nvmedev}" -n 1

(Going off of https://github.com/linux-nvme/nvme-cli/issues/174). Does that seem sane?

The last two tests sometimes fail like this:

nvme/016 (create/delete many NVMeOF block device-backed ns and test discovery) [failed]
runtime ... 44.535s

    --- tests/nvme/016.out      2018-06-25 11:56:39.176313626 -0700
    +++ results/nodev/nvme/016.out.bad  2018-06-25 11:59:30.153990955 -0700
    @@ -1,6 +1,6 @@
     Running nvme/016

    -Discovery Log Number of Records 1, Generation counter 1
    +Discovery Log Number of Records 1, Generation counter 3
     =====Discovery Log Entry 0======
     trtype:  loop
     adrfam:  pci
Quoted 2 lines

I don't know enough about NVMe to know how important this is, but it looks like this needs some sort of filter :)

Actually, the last test is just broken. It uses loop_dev which isn't defined. Please fix that, too :)

Read the cover letter in its thread