Skip to content

pre-ipv6-only clean up patchset

Antonio Quartulli openvpn-devel 2 versions In review

Get series with b4
b4 am [email protected]...

Versions newest first · linked by author and title

  1. v2 Latest3 patches 3 repliesIn review
  2. v13 patches 7 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3tun: ensure gc and argv are properly handledsrc/openvpn/tun.c+5 -31 reply
2/3tun: always pass a valid tt pointersrc/openvpn/init.c src/openvpn/tun.c+252 -2561 reply
3/3tun: get rid of tt->did_ifconfig membersrc/openvpn/tun.c src/openvpn/tun.h+1 -121 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchGert Doering
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Openvpn-devel] [PATCH v2 0/3] pre-ipv6-only clean up patchset

This patchset is the result of some of Gert's comment on the IPv6-only patchset.

For this reason, this patchset is expected to be applied *before* applying future versions (v3...) of the IPv6-only patchset.

This patchset is mostly about restyling the code a bit and getting rid of unused members. Hence, there is no new feature being introduced.

Patch 1 is fixing potential memory leaks resulting from not releasing some argv local variables and removes unused gc_areas.

This version 2 is basically addressing all the coments raised by Gert on the previous version.
Detailed changes are rpeorted in each patch.

Cheers,

p.s. buildbot is currently unusable due to the ongoing maintenance on the OpenVPN servers and therefor eonly local tests have been performed.

Antonio Quartulli (3):
tun: ensure gc and argv are properly handled
tun: always pass a valid tt pointer
tun: get rid of tt->did_ifconfig member

 src/openvpn/init.c |   7 +-
 src/openvpn/tun.c  | 513 ++++++++++++++++++++++-----------------------
 src/openvpn/tun.h  |   1 -
 3 files changed, 254 insertions(+), 267 deletions(-)
Signature · 1 line
2.17.1