Skip to content

block: Remove deprecated -drive options

Kevin Wolf qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 5 repliesIn review
  2. v13 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- Simplified hd-geo-test code after removing test cases [Markus]
- Split patch 3 and 4 so that the deprecation warning code can be easily restored if we ever need it again [Markus]

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4block: Remove deprecated -drive geometry optionsblockdev.c hmp-commands.hx hw/block/block.c +4 more+9 -1311 reply
2/4block: Remove deprecated -drive option addrblockdev.c device-hotplug.c include/sysemu/blockdev.h +2 more+2 -300 replies
3/4block: Remove deprecated -drive option serialblock/block-backend.c blockdev.c hw/block/block.c +11 more+8 -482 replies
4/4block: Remove dead deprecation warning codeblockdev.c+0 -121 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchMarkus ArmbrusterJeff Cody
1/4R-b
2/4R-b R-b
3/4R-b R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/4] block: Remove deprecated -drive options

We deprecated a bunch of -drive options in 2.10, so let's remove them for 3.0.

v2:
- Simplified hd-geo-test code after removing test cases [Markus]
- Split patch 3 and 4 so that the deprecation warning code can be easily restored if we ever need it again [Markus]

Kevin Wolf (4):
block: Remove deprecated -drive geometry options
block: Remove deprecated -drive option addr
block: Remove deprecated -drive option serial
block: Remove dead deprecation warning code

 include/hw/block/block.h  |   1 -
 include/sysemu/blockdev.h |   3 --
 block/block-backend.c     |   1 -
 blockdev.c                | 110 ----------------------------------------------
 device-hotplug.c          |   4 --
 hw/block/block.c          |  27 ------------
 hw/block/nvme.c           |   1 -
 hw/block/virtio-blk.c     |   1 -
 hw/ide/qdev.c             |   1 -
 hw/scsi/scsi-disk.c       |   1 -
 hw/usb/dev-storage.c      |   1 -
 tests/ahci-test.c         |   6 +--
 tests/hd-geo-test.c       |  37 +++-------------
 tests/ide-test.c          |   8 ++--
 hmp-commands.hx           |   1 -
 qemu-doc.texi             |  15 -------
 qemu-options.hx           |  14 +-----
 17 files changed, 15 insertions(+), 217 deletions(-)
Signature · 1 line
2.13.6