bitmap: Introduce alloc/free helpers
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest5 patches 8 repliesIn review
- v35 patches 12 repliesSuperseded
- v25 patches 16 repliesSuperseded
Changes in v4 from the cover letter
- split DM part and do rename accordingly (Mike)
- explain better in the commit message why we can't make helpers as inliners (Dmitry, Andrew)
- drop applied orphaned patch
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | dm: Avoid namespace collision with bitmap APIdrivers/ | +10 | 1 reply | |
| 2/5 | md: Avoid namespace collision with bitmap APIdrivers/ drivers/ drivers/ +6 more | +278 | 1 reply | |
| 3/5 | bitmap: Add bitmap_alloc(), bitmap_zalloc() and bitmap_free()include/ lib/ | +27 | 2 replies | |
| 4/5 | Input: gpio-keys - Switch to bitmap_zalloc()drivers/ | +4 | 0 replies | |
| 5/5 | Input: evdev - Switch to bitmap APIdrivers/ | +7 | 0 replies |
Reviews trailers per patch
4 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Dmitry Torokhov | Shaohua Li | Mike Snitzer |
|---|---|---|---|
| 1/5 | A-b | ||
| 2/5 | A-b | ||
| 3/5 | |||
| 4/5 | A-b | ||
| 5/5 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v4 0/5] bitmap: Introduce alloc/free helpers
A lot of code is using allocation of bitmaps using BITS_PER_LONG() macro and sizeof(unsigned long) operator. The readability suffers because of this.
The series introduces three helpers, i.e. bitmap_alloc(), bitmap_zalloc() and bitmap_free(), to make it more cleaner.
Patches 1 and 2 are preparatory to avoid namespace collisions between bitmap API and DM / MD bitmap. No functional changes intended.
Patch 3 introduces new helpers.
Patches 4 and 5 is just an example how to use new helpers. Locally I have like dozen of them against different subsystems and drivers.
Taking above into consideration it might make sense to have an immutable branch for this cycle.
Ideally it would go through Input subsystem, thus, needs an Ack from MD / DM maintainer(s).
Since v3:
- split DM part and do rename accordingly (Mike)
- explain better in the commit message why we can't make helpers as inliners (Dmitry, Andrew)
- drop applied orphaned patch
Since v2:
- fix compilation issue in MD bitmap code
- elaborate changes in commit message of patch 5
Since v1:
- added namespace fix patch against MD bitmap API
- moved functions to lib/bitmap.c to avoid circular dependencies
- appended Dmitry's tags
Andy Shevchenko (5):
dm: Avoid namespace collision with bitmap API
md: Avoid namespace collision with bitmap API
bitmap: Add bitmap_alloc(), bitmap_zalloc() and bitmap_free()
Input: gpio-keys - Switch to bitmap_zalloc()
Input: evdev - Switch to bitmap API
drivers/input/evdev.c | 16 +- drivers/input/keyboard/gpio_keys.c | 8 +- drivers/md/dm-raid.c | 6 +- drivers/md/md-bitmap.c | 305 +++++++++--------- drivers/md/md-bitmap.h | 60 ++-- drivers/md/md-cluster.c | 18 +- drivers/md/md.c | 44 +-- .../md/persistent-data/dm-space-map-common.c | 20 +- drivers/md/raid1.c | 35 +- drivers/md/raid10.c | 52 ++- drivers/md/raid5-cache.c | 8 +- drivers/md/raid5.c | 44 +-- include/linux/bitmap.h | 8 + lib/bitmap.c | 19 ++ 14 files changed, 326 insertions(+), 317 deletions(-)
Signature · 1 line
2.18.0