Skip to content

Delete unused methods in EWAH bitmap

Derrick Stolee git 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 4 repliesIn review
  2. v18 patches 6 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7ewah/bitmap.c: delete unused 'bitmap_clear()'ewah/bitmap.c ewah/ewok.h+0 -90 replies
2/7ewah/bitmap.c: delete unused 'bitmap_each_bit()'ewah/bitmap.c ewah/ewok.h+0 -250 replies
3/7ewah_bitmap: delete unused 'ewah_and()'ewah/ewah_bitmap.c ewah/ewok.h+0 -730 replies
4/7ewah_bitmap: delete unused 'ewah_and_not()'ewah/ewah_bitmap.c ewah/ewok.h+0 -780 replies
5/7ewah_bitmap: delete unused 'ewah_not()'ewah/ewah_bitmap.c ewah/ewok.h+0 -260 replies
6/7ewah_bitmap: delete unused 'ewah_or()'ewah/ewah_bitmap.c ewah/ewok.h+0 -740 replies
7/7ewah_io: delete unused 'ewah_serialize()'ewah/ewah_io.c ewah/ewok.h+0 -110 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/7] Delete unused methods in EWAH bitmap

The EWAH bitmap code includes several logical operations that are important for a general-purpose bitmap library. However, Git only uses the XOR operation for storing deltas between reachability bitmaps. This means that we can delete the following unused methods:

* ewah_and()
* ewah_and_not()
* ewah_not()
* ewah_or()
* ewah_serialize()

We can also delete the unused methods bitmap_clear() and bitmap_each_bit().

Derrick Stolee (7):
ewah/bitmap.c: delete unused 'bitmap_clear()' ewah/bitmap.c: delete unused 'bitmap_each_bit()'
ewah_bitmap: delete unused 'ewah_and()'
ewah_bitmap: delete unused 'ewah_and_not()'
ewah_bitmap: delete unused 'ewah_not()'
ewah_bitmap: delete unused 'ewah_or()'
ewah_io: delete unused 'ewah_serialize()'

 ewah/bitmap.c      |  32 -------
 ewah/ewah_bitmap.c | 229 ---------------------------------------------
 ewah/ewah_io.c     |  10 --
 ewah/ewok.h        |  25 -----
 4 files changed, 296 deletions(-)

base-commit: fc54c1af3ec09bab8b8ea09768c2da4069b7f53e

Signature · 1 line
2.18.0.rc1