Skip to content

nbd: support for authorization control on TLS connections

Daniel P. Berrangé qemu-devel 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 patches 8 repliesIn review
  2. v52 patches 5 repliesSuperseded
  3. v4 posting 2/26 patches 0 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v4 posting 1/21 of 17 patches2 repliesSuperseded
v36 patches9 repliesSuperseded
v26 patches8 repliesSuperseded
v16 patches12 repliesSuperseded

Changes in v6 from the cover letter

- Fix qapi annotations
- Add qemu-nbd example
- Reject authz parameter with --list

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3qemu-nbd: add support for authorization of TLS clientsinclude/block/nbd.h nbd/server.c qemu-nbd.c +3 more+71 -126 replies
2/3nbd: allow authorization with nbd-server-start QMP commandblockdev-nbd.c hmp.c include/block/nbd.h +1 more+17 -60 replies
3/3nbd: fix outdated qapi docs syntax for tls-credsqapi/block.json+1 -11 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchJuan QuintelaEric Blake
1/3R-b R-b
2/3R-b R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [Qemu-devel] [PATCH v6 0/3] nbd: support for authorization control on TLS connections

This series provides the NBD parts of the authorization control series previously posted as:

v1: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg04482.html
v2: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg05727.html
v3: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg01639.html
v4: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg04319.html

Then separated for merge:

v5: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg07347.html

The core authz framework is now merged & these patches have all had positive review. Thus these NBD parts are ready to go into the NBD maintainer's tree, should the maintainer consider them acceptable.

Changed in v6:

- Fix qapi annotations
- Add qemu-nbd example
- Reject authz parameter with --list

Daniel P. Berrangé (3):
qemu-nbd: add support for authorization of TLS clients
nbd: allow authorization with nbd-server-start QMP command
nbd: fix outdated qapi docs syntax for tls-creds

 blockdev-nbd.c             | 11 ++++++++---
 hmp.c                      |  2 +-
 include/block/nbd.h        |  4 ++--
 nbd/server.c               | 10 +++++-----
 qapi/block.json            | 10 ++++++++--
 qemu-nbd.c                 | 18 +++++++++++++++++-
 qemu-nbd.texi              | 11 +++++++++--
 tests/qemu-iotests/233     | 31 ++++++++++++++++++++++++++++---
 tests/qemu-iotests/233.out | 11 +++++++++++
 9 files changed, 89 insertions(+), 19 deletions(-)
Signature · 1 line
2.20.1