Skip to content

leds: add devicetree functionality to lltc,lt3593 driver

Daniel Mack linux-devicetree 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest5 patches 2 repliesIn review
  2. v45 patches 4 repliesSuperseded
  3. v35 patches 2 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v25 patches3 repliesSuperseded
v15 patches3 repliesSuperseded

Changes in v5 from the cover letter

* Moved GPIO property from LED subnode to device node, as requested by Rob Herring.
* Squashed the patch titled "sync module license information with header" in 5/5.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5dt-bindings: leds: Add bindings for lltc,lt3593Documentation/devicetree/bindings/leds/leds-lt3593.txt+32 -01 reply
2/5leds: lt3593: merge functions and clean up codedrivers/leds/leds-lt3593.c+35 -680 replies
3/5leds: lt3593: switch to gpiod interfacedrivers/leds/leds-lt3593.c+12 -140 replies
4/5leds: lt3593: Add device tree probing gluedrivers/leds/leds-lt3593.c+70 -00 replies
5/5leds: lt3593: update email address and switch to SPDX license headerdrivers/leds/leds-lt3593.c+4 -190 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchRob Herring
1/5R-b
2/5
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/5] leds: add devicetree functionality to lltc,lt3593 driver

This is v5 of the series that brings devicetree support for the lltc,lt3593 LED driver.

Before this series, the driver supported controlling multiple LEDs through an array in the platform data. IOW, a single instance of the driver was able to control multiple hardware chips.

This series changes that, and requires a distinct platform device to be set up for each of them, if a board has multiple of these hardware chips. The reason is that in DT, nodes should represent hardware, and it's much cleaner this way.

As stated earlier in the thread for v1, the driver currently only has one user in mainline (the Raumfeld platform) which is soon to be replaced by a devicetree file. This user only uses one LED via pdata, so the change mentioned above does not cause a regression.

Once the platform is fully ported to DT, I'll send another patch that removes pdata handling from this driver completely, but it's kept around as legacy bridge for now.

Changelog:

v4 → v5:
* Moved GPIO property from LED subnode to device node, as requested by Rob Herring.
* Squashed the patch titled "sync module license information with header" in 5/5.

v3 → v4:

* Fixed a mishap that slipped in during rebase which caused a compile error
* Removed empty line at end of the DT documentation file
* Switched to SPDX license header in the driver

v2 → v3:

* Fixed a typo in the commit log of 1/5
* Rebased onto 4.18-rc1

v1 → v2:

* Moved LED-specific properties into a sub-node in DT, as requested by Jacek Anaszewski.

Daniel Mack (5):
dt-bindings: leds: Add bindings for lltc,lt3593
leds: lt3593: merge functions and clean up code
leds: lt3593: switch to gpiod interface
leds: lt3593: Add device tree probing glue
leds: lt3593: update email address and switch to SPDX license header

 .../devicetree/bindings/leds/leds-lt3593.txt  |  32 +++
 drivers/leds/leds-lt3593.c                    | 190 ++++++++++--------
 2 files changed, 137 insertions(+), 85 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-lt3593.txt
Signature · 1 line
2.17.1