Skip to content

xfs_buf_submit[_wait]() cleanups

Brian Foster linux-xfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2xfs: combine [a]sync buffer submission apisfs/xfs/xfs_buf.c fs/xfs/xfs_buf.h fs/xfs/xfs_log_recover.c+33 -532 replies
2/2xfs: kill __xfs_buf_submit_common()fs/xfs/xfs_buf.c+34 -492 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchDarrick J. WongChristoph Hellwig
1/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] xfs_buf_submit[_wait]() cleanups

These are just a couple cleanups for buffer I/O submission based on suggestions from Christoph. This applies on top of the previously posted delwri queue fix [1].

The combination of both slightly circuitously condenses the buf submission path back into a single helper, but we end up in the same place either way. I'm sending this separately because review of the value of this interface refactor is independent of the internal refactor required to implement the aforementioned bug fix.

Thoughts, reviews, flames appreciated.

[1] https://marc.info/?l=linux-xfs&m=152908593803756&w=2

Brian

Brian Foster (2):
xfs: combine [a]sync buffer submission apis
xfs: kill __xfs_buf_submit_common()

 fs/xfs/xfs_buf.c         | 125 +++++++++++++--------------------------
 fs/xfs/xfs_buf.h         |  10 +++-
 fs/xfs/xfs_log_recover.c |   4 +-
 3 files changed, 52 insertions(+), 87 deletions(-)
Signature · 1 line
2.17.1