Skip to content

qcow2 check improvements part I

Vladimir Sementsov-Ogievskiy qemu-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest5 patches 2 repliesIn review
  2. v45 patches 9 repliesSuperseded
  3. v38 patches 0 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v27 patches23 repliesSuperseded
v17 patches5 repliesSuperseded

Changes in v5 from the cover letter

01: - add Max's r-b
02: - s/it's/it/ in comment in block/qcow2-refcount.c [Max]
- fix comment style accordingly to updated checkpatch ('/*' on separate line)
- add Max's r-b
04: - add Max's r-b
05: - refactor change in check_oflag_copied, to increase

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5qcow2-refcount: fix check_oflag_copiedblock/qcow2-refcount.c+4 -40 replies
2/5qcow2-refcount: avoid eating RAMblock/qcow2-refcount.c tests/qemu-iotests/138 tests/qemu-iotests/138.out+28 -80 replies
3/5qcow2-refcount: check_refcounts_l2: reduce ignored overlapsblock/qcow2-refcount.c+9 -70 replies
4/5qcow2-refcount: check_refcounts_l2: don't count fixed cluster as allocatedblock/qcow2-refcount.c+9 -90 replies
5/5qcow2-refcount: don't mask corruptions under internal errorsblock/qcow2-refcount.c+9 -101 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchMax Reitz
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [Qemu-devel] [PATCH v5 0/5] qcow2 check improvements part I

Hi all!

v5:
01: - add Max's r-b
02: - s/it's/it/ in comment in block/qcow2-refcount.c [Max]
- fix comment style accordingly to updated checkpatch ('/*' on separate line)
- add Max's r-b
04: - add Max's r-b
05: - refactor change in check_oflag_copied, to increase

      res->corruptions separately from l2_dirty variable [Max]

v4 was derived from "[PATCH v3 0/8] qcow2 check improvements"
(https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02284.html)

v4:
Some patches are new, some patches are not included and are postponed to part II.

01,03 - unchanged
02: handle broken iotest
04-05: new

Vladimir Sementsov-Ogievskiy (5):
qcow2-refcount: fix check_oflag_copied
qcow2-refcount: avoid eating RAM
qcow2-refcount: check_refcounts_l2: reduce ignored overlaps
qcow2-refcount: check_refcounts_l2: don't count fixed cluster as
allocated
qcow2-refcount: don't mask corruptions under internal errors

 block/qcow2-refcount.c     | 80 ++++++++++++++++++++++++--------------
 tests/qemu-iotests/138     | 12 +++---
 tests/qemu-iotests/138.out |  5 ++-
 3 files changed, 59 insertions(+), 38 deletions(-)
Signature · 1 line
2.18.0