Skip to content

Add devicetree functionality to w1 busses and ds2760

Daniel Mack linux-devicetree linux-pm lkml 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 9 repliesIn review
  2. v3 posting 2/24 patches 2 repliesSuperseded
  3. v3 posting 1/24 patches 1 replySuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v24 patches3 repliesSuperseded
v1 RFC4 patches3 repliesSuperseded

Changes in v4 from the cover letter

* Property name cleanups
* Dropped maxim,current-accumulator property
* Split 1st patch of v3 in two

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5dt-bindings: w1: document generic onewire bindingsDocumentation/devicetree/bindings/w1/w1-gpio.txt Documentation/devicetree/bindings/w1/w1.txt+33 -34 replies
2/5dt-bindings: w1: document bindings for ds2760 battery monitorDocumentation/devicetree/bindings/power/supply/maxim,ds2760.txt+26 -01 reply
3/5w1: core: match sub-nodes of bus masters in devicetreedrivers/w1/w1.c include/linux/w1.h+5 -02 replies
4/5power: supply: ds2760_battery: merge ds2760 supply driver with its w1 slave companiondrivers/power/supply/Kconfig drivers/power/supply/ds2760_battery.c drivers/w1/slaves/Kconfig +3 more+232 -3381 reply
5/5power: supply: ds2760_battery: add devicetree probingdrivers/power/supply/ds2760_battery.c+28 -11 reply

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by.

PatchRob Herring
1/5R-b
2/5R-b
3/5
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/5] Add devicetree functionality to w1 busses and ds2760

This patch set contains five patches that bring devicetree functionality to w1 bus masters and slaves in general. As an example, the ds2760 driver is made aware of devicetree probing. Other drivers can easily be ported later.

W1 masters scan their bus in order to discover slave devices. Once one is found, a driver matching the family of the device is instanciated which handles it. To add devicetree functionality, all that's needed for now is a call to of_find_matching_node() when a slave device is attached, so the corresponding of_node pointer is set.

The series also contains a patch that merges the w1 slave driver for the ds2760 battery monitor into its only user, the ds2760 supply driver. The indirection with two drivers never had any benefit, and here is a good opportunity to clean this up.

Patch #1 and #2 add DT bindings documentation
Patch #3 adds the call to of_find_matching_node() Patch #4 merges the w1 slave and the supply driver for ds2760 Patch #5 makes the ds2760 supply driver aware of DT environments

This works fine on a PXA3xx based board with a battery attached to the w1-gpio bus master controller.

Changelog:

v3 → v4:
* Property name cleanups
* Dropped maxim,current-accumulator property
* Split 1st patch of v3 in two

v2 → v3:
* Fixed a typo in the documentation and added more real-world example for the bindings. Pointed out by Rob Herring.

Daniel Mack (4):
dt-bindings: w1: document generic onewire and DS2760 bindings
w1: core: match sub-nodes of bus masters in devicetree
power: supply: ds2760_battery: merge ds2760 supply driver with its w1
slave companion
power: supply: ds2760_battery: add devicetree probing

Daniel Mack (5):
dt-bindings: w1: document generic onewire bindings
dt-bindings: w1: document bindings for ds2760 battery monitor
w1: core: match sub-nodes of bus masters in devicetree
power: supply: ds2760_battery: merge ds2760 supply driver with its w1
slave companion
power: supply: ds2760_battery: add devicetree probing

 .../bindings/power/supply/maxim,ds2760.txt    |  26 ++
 .../devicetree/bindings/w1/w1-gpio.txt        |  11 +-
 Documentation/devicetree/bindings/w1/w1.txt   |  25 ++
 drivers/power/supply/Kconfig                  |   2 +-
 drivers/power/supply/ds2760_battery.c         | 348 +++++++++++++-----
 drivers/w1/slaves/Kconfig                     |  12 -
 drivers/w1/slaves/Makefile                    |   1 -
 drivers/w1/slaves/w1_ds2760.c                 | 175 ---------
 drivers/w1/slaves/w1_ds2760.h                 |  59 ---
 drivers/w1/w1.c                               |   3 +
 include/linux/w1.h                            |   2 +
 11 files changed, 323 insertions(+), 341 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/power/supply/maxim,ds2760.txt
 create mode 100644 Documentation/devicetree/bindings/w1/w1.txt
 delete mode 100644 drivers/w1/slaves/w1_ds2760.c
 delete mode 100644 drivers/w1/slaves/w1_ds2760.h
Signature · 1 line
2.17.1