RFC iommu/iova: Unsafe locking in find_iova()
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest3 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | iommu/iova: Find and split iova under rbtree's lockdrivers/ drivers/ include/ | +19 | 0 replies | |
| 2/3 | iommu/iova: Make free_iova() atomicdrivers/ | +6 | 0 replies | |
| 3/3 | iommu/iova: Remove find_iova()drivers/ include/ | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC 0/3] iommu/iova: Unsafe locking in find_iova()
find_iova() looks to be using a bad locking practice: it locks the returned iova only for the search time.
And looking in code, the element can be removed from the tree and freed under rbtree lock. That happens during memory hot-unplug and cleanup on module removal.
Here I cleanup users of the function and delete it.
Dmitry Safonov (3):
iommu/iova: Find and split iova under rbtree's lock iommu/iova: Make free_iova() atomic iommu/iova: Remove find_iova()
drivers/iommu/intel-iommu.c | 14 +++---------- drivers/iommu/iova.c | 48 +++++++++++++++++---------------------------- include/linux/iova.h | 17 ++++------------ 3 files changed, 25 insertions(+), 54 deletions(-)
Signature · 1 line
2.13.6