linux-user: strace improvements
Status from this message: Applied to my linux-user branch.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v8 Latest9 patches 12 repliesApplied
- v75 of 9 patches 10 repliesSuperseded
- v68 patches 6 repliesApplied
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v5 | 8 of 10 patches | 1 reply | Superseded | |
| v4 | 7 of 12 patches | 0 replies | Superseded | |
| v3 | 9 of 13 patches | 15 replies | Superseded | |
| v2 | 9 of 12 patches | 3 replies | Superseded |
Changes in v8 from the cover letter
- use tswap32,
- do not name print_sockaddr prototype arguments
- use abi_int for target_sockaddr_ll.sll_ifindex
- added R-b tags
Patches in v8 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | linux-user/strace: Display invalid pointer in print_timeval()linux-user/ | +3 | 1 reply | |
| 2/9 | linux-user/strace: Add print_timezone()linux-user/ | +20 | 2 replies | |
| 3/9 | linux-user/strace: Improve settimeofday()linux-user/ linux-user/ | +14 | 1 reply | |
| 4/9 | linux-user/syscall: Introduce target_sockaddr_nllinux-user/ linux-user/ | +11 | 1 reply | |
| 5/9 | linux-user/strace: Dump AF_NETLINK sockaddr contentlinux-user/ | +37 | 1 reply | |
| 6/9 | linux-user/strace: Add print_sockfd()linux-user/ | +16 | 1 reply | |
| 7/9 | linux-user/strace: Improve bind() outputlinux-user/ linux-user/ | +15 | 1 reply | |
| 8/9 | linux-user/strace: Let print_sockaddr() have a 'last' argumentlinux-user/ | +5 | 2 replies | |
| 9/9 | linux-user/syscall: Align target_sockaddr fields using ABI typeslinux-user/ | +17 | 2 replies |
Reviews trailers per patch
All 9 patches have a Reviewed-by or Acked-by.
| Patch | Laurent Vivier | Guido Günther |
|---|---|---|
| 1/9 | R-b | |
| 2/9 | R-b R-b | |
| 3/9 | R-b | T-b |
| 4/9 | R-b | T-b |
| 5/9 | R-b | T-b |
| 6/9 | R-b | |
| 7/9 | R-b | T-b |
| 8/9 | R-b R-b | |
| 9/9 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v8 0/9] linux-user: strace improvements
Hi Laurent,
Few patches I'v been writting while trying to figure out this issue:
http://lists.nongnu.org/archive/html/qemu-arm/2018-01/msg00514.html
As usual with linux-user files, this series will trigger some checkpatch benign warnings.
Regards,
Phil.
Since v7:
- use tswap32,
- do not name print_sockaddr prototype arguments
- use abi_int for target_sockaddr_ll.sll_ifindex
- added R-b tags
Since v6:
- Use ABI types in sockaddr
Since v5:
- dropped 'Verify recvfrom(addr)' since failing LTP testsuite (see [1])
- also define print_sockfd() for bind() (patches #6 and #7)
Since v4:
- rebased on master (no change)
Since v3:
- addressed Laurent comments
- added print_sockfd()
- removed the print_sockaddr_ptr() patch, also the two getsockname()/recvfrom() patches for after 3.0.
Since v2:
- display invalid pointer in print_timeval() and print_timezone()
- do not display gettimeofday() arguments
Since v1:
- addressed Laurent comments
- added 'last' argument to print_sockaddr()
- reordered series, so patches already correct can get applied directly
- dropped "linux-user/syscall: simplify recvfrom()" for now
v1: http://lists.nongnu.org/archive/html/qemu-devel/2018-01/msg05855.html
v2: http://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg08216.html
v3: http://lists.nongnu.org/archive/html/qemu-devel/2018-07/msg00411.html
v5: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02067.html
v6: https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg01346.html
v7: https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg03114.html
[1] https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02807.html
Philippe Mathieu-Daudé (9):
linux-user/strace: Display invalid pointer in print_timeval() linux-user/strace: Add print_timezone() linux-user/strace: Improve settimeofday() linux-user/syscall: Introduce target_sockaddr_nl linux-user/strace: Dump AF_NETLINK sockaddr content linux-user/strace: Add print_sockfd() linux-user/strace: Improve bind() output linux-user/strace: Let print_sockaddr() have a 'last' argument linux-user/syscall: Align target_sockaddr fields using ABI types
linux-user/strace.c | 120 +++++++++++++++++++++++++++++++++----- linux-user/strace.list | 4 +- linux-user/syscall.c | 6 +- linux-user/syscall_defs.h | 41 +++++++------ 4 files changed, 137 insertions(+), 34 deletions(-)
Signature · 1 line
2.21.0