Skip to content

linux-user: strace improvements

Philippe Mathieu-Daudé qemu-devel 7 versions – Applied

Status from this message: Applied to my linux-user branch.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest9 patches 12 repliesApplied
  2. v75 of 9 patches 10 repliesSuperseded
  3. v68 patches 6 repliesApplied
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v58 of 10 patches1 replySuperseded
v47 of 12 patches0 repliesSuperseded
v39 of 13 patches15 repliesSuperseded
v29 of 12 patches3 repliesSuperseded

Changes in v8 from the cover letter

- use tswap32,
- do not name print_sockaddr prototype arguments
- use abi_int for target_sockaddr_ll.sll_ifindex
- added R-b tags

Patches in v8 Applied

#Subject and filesSizeRepliesApplied
1/9linux-user/strace: Display invalid pointer in print_timeval()linux-user/strace.c+3 -11 reply
2/9linux-user/strace: Add print_timezone()linux-user/strace.c+20 -02 replies
3/9linux-user/strace: Improve settimeofday()linux-user/strace.c linux-user/strace.list+14 -11 reply
4/9linux-user/syscall: Introduce target_sockaddr_nllinux-user/syscall.c linux-user/syscall_defs.h+11 -21 reply
5/9linux-user/strace: Dump AF_NETLINK sockaddr contentlinux-user/strace.c+37 -01 reply
6/9linux-user/strace: Add print_sockfd()linux-user/strace.c+16 -71 reply
7/9linux-user/strace: Improve bind() outputlinux-user/strace.c linux-user/strace.list+15 -21 reply
8/9linux-user/strace: Let print_sockaddr() have a 'last' argumentlinux-user/strace.c+5 -52 replies
9/9linux-user/syscall: Align target_sockaddr fields using ABI typeslinux-user/syscall_defs.h+17 -172 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchLaurent VivierGuido Günther
1/9R-b
2/9R-b R-b
3/9R-b T-b
4/9R-b T-b
5/9R-b T-b
6/9R-b
7/9R-b T-b
8/9R-b R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v8 thread

Cover letter [PATCH v8 0/9] linux-user: strace improvements

Hi Laurent,

Few patches I'v been writting while trying to figure out this issue:
http://lists.nongnu.org/archive/html/qemu-arm/2018-01/msg00514.html

As usual with linux-user files, this series will trigger some checkpatch benign warnings.

Regards,

Phil.

Since v7:
- use tswap32,
- do not name print_sockaddr prototype arguments
- use abi_int for target_sockaddr_ll.sll_ifindex
- added R-b tags

Since v6:
- Use ABI types in sockaddr

Since v5:
- dropped 'Verify recvfrom(addr)' since failing LTP testsuite (see [1])
- also define print_sockfd() for bind() (patches #6 and #7)

Since v4:
- rebased on master (no change)

Since v3:
- addressed Laurent comments
- added print_sockfd()
- removed the print_sockaddr_ptr() patch, also the two getsockname()/recvfrom() patches for after 3.0.

Since v2:
- display invalid pointer in print_timeval() and print_timezone()
- do not display gettimeofday() arguments

Since v1:
- addressed Laurent comments
- added 'last' argument to print_sockaddr()
- reordered series, so patches already correct can get applied directly
- dropped "linux-user/syscall: simplify recvfrom()" for now

v1: http://lists.nongnu.org/archive/html/qemu-devel/2018-01/msg05855.html
v2: http://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg08216.html
v3: http://lists.nongnu.org/archive/html/qemu-devel/2018-07/msg00411.html
v5: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02067.html
v6: https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg01346.html
v7: https://lists.gnu.org/archive/html/qemu-devel/2019-09/msg03114.html
[1] https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02807.html

Philippe Mathieu-Daudé (9):
linux-user/strace: Display invalid pointer in print_timeval() linux-user/strace: Add print_timezone() linux-user/strace: Improve settimeofday() linux-user/syscall: Introduce target_sockaddr_nl linux-user/strace: Dump AF_NETLINK sockaddr content linux-user/strace: Add print_sockfd() linux-user/strace: Improve bind() output linux-user/strace: Let print_sockaddr() have a 'last' argument linux-user/syscall: Align target_sockaddr fields using ABI types

 linux-user/strace.c       | 120 +++++++++++++++++++++++++++++++++-----
 linux-user/strace.list    |   4 +-
 linux-user/syscall.c      |   6 +-
 linux-user/syscall_defs.h |  41 +++++++------
 4 files changed, 137 insertions(+), 34 deletions(-)
Signature · 1 line
2.21.0