Skip to content

Postponed actions

Denis Plotnikov qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v0 Latest2 patches 21 repliesIn review

Patches in v0 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2async: add infrastructure for postponed actionsinclude/block/aio.h util/async.c+96 -00 replies
2/2block: postpone the coroutine executing if the BDS's is drainedblock/block-backend.c+46 -127 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v0 yet.

Read the v0 thread

Cover letter [Qemu-devel] [PATCH v0 0/2] Postponed actions

There are cases when a request to a block driver state shouldn't have appeared producing dangerous race conditions.
This misbehaviour is usually happens with storage devices emulated without eventfd for guest to host notifications like IDE.

The issue arises when the context is in the "drained" section and doesn't expect the request to come, but request comes from the device not using iothread and which context is processed by the main loop.

The main loop apart of the iothread event loop isn't blocked by the "drained" section.
The request coming and processing while in "drained" section can spoil the block driver state consistency.

This behavior can be observed in the following KVM-based case:

1. Setup a VM with an IDE disk.
2. Inside a VM start a disk writing load for the IDE device e.g: dd if=<file> of=<file> bs=X count=Y oflag=direct
3. On the host create a mirroring block job for the IDE device e.g: drive_mirror <your_IDE> <your_path>
4. On the host finish the block job
e.g: block_job_complete <your_IDE>

Having done the 4th action, you could get an assert:
assert(QLIST_EMPTY(&bs->tracked_requests)) from mirror_run. On my setup, the assert is 1/3 reproducible.

The patch series introduces the mechanism to postpone the requests until the BDS leaves "drained" section for the devices not using iothreads. Also, it modifies the asynchronous block backend infrastructure to use that mechanism to release the assert bug for IDE devices.

Denis Plotnikov (2):
async: add infrastructure for postponed actions
block: postpone the coroutine executing if the BDS's is drained

 block/block-backend.c | 58 ++++++++++++++++++++++++++++++---------
 include/block/aio.h   | 63 +++++++++++++++++++++++++++++++++++++++++++
 util/async.c          | 33 +++++++++++++++++++++++
 3 files changed, 142 insertions(+), 12 deletions(-)
Signature · 1 line
2.17.0