staging:rtl8192u: One significant change...
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest10 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | staging:rtl8192u: typedef struct tx_desc_819x_usb > struct tx_desc_819x_usbdrivers/ drivers/ | +5 | 0 replies | |
| 2/10 | staging:rtl8192u: trim multiple blank lines - Coding Styledrivers/ | +0 | 0 replies | |
| 3/10 | staging:rtl8192u: remove unused structure tx_desc_819x_usb_aggr_subframedrivers/ | +0 | 0 replies | |
| 4/10 | staging:rtl8192u: Rename file macro to avoid camel case - Coding Styledrivers/ | +2 | 2 replies | |
| 5/10 | staging:rtl8192u: typedef struct tx_desc_cmd_819x_usb remove typedefdrivers/ drivers/ | +3 | 0 replies | |
| 6/10 | staging:rtl8192u: typedef struct tx_fwinfo_819x_usb remove typedefdrivers/ drivers/ | +8 | 0 replies | |
| 7/10 | staging:rtl8192u: typedef struct rx_desc_819x_usb remove typedefdrivers/ drivers/ | +9 | 0 replies | |
| 8/10 | staging:rtl8192u: Remove struct rx_desc_819x_usb_aggr_subframedrivers/ | +0 | 0 replies | |
| 9/10 | staging:rtl8192u: remove typedef from struct rx_drvinfo_819x_usbdrivers/ drivers/ | +7 | 0 replies | |
| 10/10 | staging:rtl8192u: Change struct r8192_priv member Rf_Mode from u8 > enumdrivers/ | +4 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [0/10] staging:rtl8192u: One significant change...
The first 9 patches in this series are coding style changes, including a number of patches to remove the "typedef" directive from a number of data structure definitions. This clears the checkpatch warning about defining new data types in the code.
The last patch in the series, however, changes the data type of a member variable from a u8 to an enumerated type. Generally in C an enumerated type is implemented by the compiler as an int, but can be changed by compiler directives. Either way the member variable will most probably have its size changed by this patch. I don't think that the structure is mapped to hardware or physical memory location, but is allocated and populated in the rtl8192_usb_probe() function in the file r8192U_core.c. Given that allocation/population I don't think that the size of the member variable is of run time significance, bar the slight increase in size of the overall structure.
The reason for doing this is to enable the compiler's checking of assignments to the variable defined as an enumerated type. The alternative is to leave the variable as a u8 and remove the enumerated type, replacing it with #define definitions of the possible values.
I raised this issue on the kernel newbies mailing list and of the two alternatives enumerated type won out.