Skip to content

nvme: ANA implementation fixes

Hannes Reinecke linux-nvme 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5nvme: count all ANA groups for ANA Log pagedrivers/nvme/target/admin-cmd.c+5 -02 replies
2/5nvmet: fixup crash on NULL device pathdrivers/nvme/target/configfs.c drivers/nvme/target/core.c+11 -15 replies
3/5nvme-multipath: fixup crash during disconnectdrivers/nvme/host/multipath.c+1 -12 replies
4/5nvme-multipath: disable ANA support if parsing failsdrivers/nvme/host/core.c drivers/nvme/host/multipath.c+51 -221 reply
4/5nvme-multipath: disable ANA support if parsing fails+0 -01 reply
5/5nvme-multipath: parse entire ANA log page in nvme_set_ns_ana_state()drivers/nvme/host/multipath.c+1 -31 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] nvme: ANA implementation fixes

Hi Christoph,

here's a set of patches relative to your nvme-ana branch. Most of these issues have been encountered when running my blktest test case (to be submitted separately). With these patches I haven't found any other issues with the ANA implementation, so we're good to go in principle.

Note, I've submitted another patch ("nvme: register ns_id attributes ...") which will probably clash with the ANA series and these patches.

But we can fix it up once we've agreed on when and how to submit the ANA series proper.

As usual, comments and reviews are welcome.

Hannes Reinecke (5):
nvme: count all ANA groups for ANA Log page
nvmet: fixup crash on NULL device path
nvme-multipath: fixup crash during disconnect
nvme-multipath: disable ANA support if parsing fails
nvme-multipath: parse entire ANA log page in nvme_set_ns_ana_state()

 drivers/nvme/host/core.c        |  2 +-
 drivers/nvme/host/multipath.c   | 77 ++++++++++++++++++++++++++++-------------
 drivers/nvme/target/admin-cmd.c |  5 +++
 drivers/nvme/target/configfs.c  |  6 ++++
 drivers/nvme/target/core.c      |  6 +++-
 5 files changed, 69 insertions(+), 27 deletions(-)
Signature · 1 line
2.12.3