Multiple fixes and improvements to TLS tests
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | tests: call qcrypto_init instead of gnutls_global_inittests/ | +3 | 1 reply | |
| 2/4 | tests: don't silence error reporting for all testsstubs/ tests/ | +7 | 2 replies | |
| 3/4 | tests: use error_abort in places expecting errorstests/ tests/ tests/ | +39 | 1 reply | |
| 4/4 | tests: fix TLS handshake failure with TLS 1.3tests/ | +2 | 1 reply |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Philippe Mathieu-Daudé | Eric Blake |
|---|---|---|
| 1/4 | R-b T-b | |
| 2/4 | R-b T-b | |
| 3/4 | R-b T-b | |
| 4/4 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH for 3.0 0/4] Multiple fixes and improvements to TLS tests
The switch to enable TLS 1.3 protocol support in GNUTLS in Fedora exposed a subtle flaw in our TLS unit tests. This was horrible to debug because of bad error reporting in our tests which caused all the error messages to be irretrievably lost instead of displayed on stderr.
Daniel P. Berrangé (4):
tests: call qcrypto_init instead of gnutls_global_init
tests: don't silence error reporting for all tests
tests: use error_abort in places expecting errors
tests: fix TLS handshake failure with TLS 1.3
stubs/error-printf.c | 5 +- tests/crypto-tls-x509-helpers.c | 4 +- tests/test-crypto-tlscredsx509.c | 11 +---- tests/test-crypto-tlssession.c | 80 ++++++++++++-------------------- tests/test-io-channel-tls.c | 24 ++++------ tests/test-vmstate.c | 3 ++ 6 files changed, 51 insertions(+), 76 deletions(-)
Signature · 1 line
2.17.1