Skip to content

Multiple fixes and improvements to TLS tests

Daniel P. Berrangé qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4tests: call qcrypto_init instead of gnutls_global_inittests/crypto-tls-x509-helpers.c+3 -11 reply
2/4tests: don't silence error reporting for all testsstubs/error-printf.c tests/test-vmstate.c+7 -12 replies
3/4tests: use error_abort in places expecting errorstests/test-crypto-tlscredsx509.c tests/test-crypto-tlssession.c tests/test-io-channel-tls.c+39 -721 reply
4/4tests: fix TLS handshake failure with TLS 1.3tests/test-crypto-tlssession.c+2 -21 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéEric Blake
1/4R-b T-b
2/4R-b T-b
3/4R-b T-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH for 3.0 0/4] Multiple fixes and improvements to TLS tests

The switch to enable TLS 1.3 protocol support in GNUTLS in Fedora exposed a subtle flaw in our TLS unit tests. This was horrible to debug because of bad error reporting in our tests which caused all the error messages to be irretrievably lost instead of displayed on stderr.

Daniel P. Berrangé (4):
tests: call qcrypto_init instead of gnutls_global_init
tests: don't silence error reporting for all tests
tests: use error_abort in places expecting errors
tests: fix TLS handshake failure with TLS 1.3

 stubs/error-printf.c             |  5 +-
 tests/crypto-tls-x509-helpers.c  |  4 +-
 tests/test-crypto-tlscredsx509.c | 11 +----
 tests/test-crypto-tlssession.c   | 80 ++++++++++++--------------------
 tests/test-io-channel-tls.c      | 24 ++++------
 tests/test-vmstate.c             |  3 ++
 6 files changed, 51 insertions(+), 76 deletions(-)
Signature · 1 line
2.17.1