fix persistent bitmaps migration logic
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 3 repliesIn review
v2 from the cover letter
- Add a new patch 4 as a prerequisite for what's now patch 5
- Rework the fix to be (hopefully) cleaner, see patch 5 notes
- Adjust error message in patch 2 (Eric)
- Adjust test logic slightly (patches 6, 7) to deal with changes in patch 5.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | iotests: 169: drop deprecated 'autoload' parametertests/ | +0 | 0 replies | |
| 2/7 | block/qcow2: improve error message in qcow2_inactivateblock/ | +3 | 0 replies | |
| 3/7 | block/qcow2: drop dirty_bitmaps_loaded state variableblock/ block/ | +2 | 0 replies | |
| 4/7 | iotests: 169: actually test block migrationtests/ | +3 | 0 replies | |
| 5/7 | dirty-bitmaps: clean-up bitmaps loading and migration logicblock.c block/ block/ +3 more | +26 | 0 replies | |
| 6/7 | iotests: improve 169tests/ | +11 | 0 replies | |
| 7/7 | iotests: 169: add cases for source vm resumingtests/ tests/ | +60 | 0 replies |
Reviews trailers per patch
2 of 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | John Snow | Stefan Hajnoczi |
|---|---|---|
| Series | R-b | |
| 1/7 | R-b | |
| 2/7 | ||
| 3/7 | R-b | |
| 4/7 | ||
| 5/7 | ||
| 6/7 | ||
| 7/7 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH for-3.0 0/7] fix persistent bitmaps migration logic
This is an updated version of Vladimir's proposal for fixing the handling around migration and persistent dirty bitmaps.
Patches 1, 4, 6, and 7 update the testing for this feature. Patch 2 touches up an error message.
Patch 3 removes dead code.
Patch 5 contains the real fix.
v2:
- Add a new patch 4 as a prerequisite for what's now patch 5
- Rework the fix to be (hopefully) cleaner, see patch 5 notes
- Adjust error message in patch 2 (Eric)
- Adjust test logic slightly (patches 6, 7) to deal with changes in patch 5.
John Snow (2):
iotests: 169: actually test block migration
dirty-bitmaps: clean-up bitmaps loading and migration logic
Vladimir Sementsov-Ogievskiy (5):
iotests: 169: drop deprecated 'autoload' parameter block/qcow2: improve error message in qcow2_inactivate block/qcow2: drop dirty_bitmaps_loaded state variable
iotests: improve 169
iotests: 169: add cases for source vm resuming
block.c | 4 --- block/dirty-bitmap.c | 20 ------------ block/qcow2-bitmap.c | 16 +++++++++ block/qcow2.c | 26 ++++----------- block/qcow2.h | 1 - include/block/dirty-bitmap.h | 2 +- migration/block-dirty-bitmap.c | 11 ++++--- tests/qemu-iotests/169 | 74 ++++++++++++++++++++++++++++++++++++++++-- tests/qemu-iotests/169.out | 4 +-- 9 files changed, 103 insertions(+), 55 deletions(-)
Signature · 1 line
2.14.4