Skip to content

fsi: Convert misc devs to proper chardevs and more

Benjamin Herrenschmidt linux-aspeed lkml openbmc 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5fsi: Add new central chardev supportdrivers/fsi/Kconfig drivers/fsi/fsi-core.c include/linux/fsi.h+119 -30 replies
2/5fsi: sbefifo: Convert to use the new chardevdrivers/fsi/fsi-sbefifo.c+55 -290 replies
3/5fsi: scom: Convert to use the new chardevdrivers/fsi/fsi-scom.c+80 -500 replies
4/5fsi: Add cfam char devicesdrivers/fsi/fsi-core.c+213 -510 replies
5/5fsi: Prevent multiple concurrent rescansdrivers/fsi/fsi-core.c drivers/fsi/fsi-master.h+16 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] fsi: Convert misc devs to proper chardevs and more

This converts the various FSI devices from misc dev to chardev, as there can potentially be too much of them for misc devs limited minors, and because there are some lifetime issues with the current support.

This provide a common infrastructure to allocate an FSI major and distribute minors in a way that keeps it compatible with existing userspace. A new representation grouping FSI devices under a /dev/fsi directory is optinally provided, which will work in conjunction with new udev scripts aimed at providing fixed ID based symlinks.

A side effect of those conversions is to fix some object lifetime issues caused by a mixup between devm_kzalloc and proper object lifetime.

This series also adds a /dev{/fsi}/cfamN chardev for raw CFAM access that will superseed the existing "raw" sysfs file.

Finally there's also a locking fix to avoid horrible mixups if the "rescan" file is poked while a rescan is already in progress.