Skip to content

Staging: octeon-usb fixes for coding style, SPDX and readability.

Georgios Tsotsos lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 4 repliesIn review
  2. v14 patches 1 replySuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Staging: octeon-usb: Adding SPDX license identifierdrivers/staging/octeon-usb/Makefile drivers/staging/octeon-usb/octeon-hcd.c drivers/staging/octeon-usb/octeon-hcd.h+3 -00 replies
2/3Staging: octeon-usb: Change coding style of CVMX_WAIT_FOR_FIELD32 marco.drivers/staging/octeon-usb/octeon-hcd.c+23 -219 replies
3/3Staging: octeon-usb: Breaks down cvmx_usb_poll_channel().drivers/staging/octeon-usb/octeon-hcd.c+54 -2912 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/3] Staging: octeon-usb fixes for coding style, SPDX and readability.

Hello,
Ok, this have gone too far, i sent these series so many times wrong... I am sorry its my first patch (and series) and i keep mix-up patch generation an sending to my self. Last time not everybody was cc.

Here are three patches which trying to resolve TODO's list requirements number 45 about octeon-usb.
There are SPDX licence additions on code, makefile and header files. Checkpatch warnings are resolved,also a notice about CVMX_WAIT_FOR_FIELD32 macro. After Joe Perches's ([email protected]) suggestion i broke down the cvmx_usb_poll_channel function in order to improve readability and keeping it under 80 columns.

Georgios Tsotsos (3):
Staging: octeon-usb: Adding SPDX license identifier
Staging: octeon-usb: Change coding style of CVMX_WAIT_FOR_FIELD32 marco.
Staging: octeon-usb: Breaks down cvmx_usb_poll_channel().

 drivers/staging/octeon-usb/Makefile     |   1 +
 drivers/staging/octeon-usb/octeon-hcd.c | 128 +++++++++++++++++++-------------
 drivers/staging/octeon-usb/octeon-hcd.h |   1 +
 3 files changed, 80 insertions(+), 50 deletions(-)
Signature · 1 line
2.16.4