Skip to content

document that NewHash is now SHA-256

Ævar Arnfjörð Bjarmason git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2doc hash-function-transition: note the lack of a changelogDocumentation/technical/hash-function-transition.txt+6 -00 replies
2/2doc hash-function-transition: pick SHA-256 as NewHashDocumentation/technical/hash-function-transition.txt+96 -9012 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchJonathan NiederJunio C HamanoLinus Torvaldsbrian m. carlsonJohannes SchindelinDan Shumow
1/2
2/2Helped-by Helped-by A-b A-b A-b A-b A-b A-b A-b A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v1 thread

Cover letter [PATCH 0/2] document that NewHash is now SHA-256
Quoted 12 lines · Junio C Hamano
Quoted 10 lines · Linus Torvalds
Quoted 7 lines · Edward Thomson

Switching gears, if I look at this from the perspective of the libgit2 project, I would also prefer SHA-256 or SHA3 over blake2b. To support blake2b, we'd have to include - and support - that code ourselves. But to support SHA-256, we would simply use the system's crypto libraries that we already take a dependecy on (OpenSSL, mbedTLS, CryptoNG, or SecureTransport).

Quoted 8 lines
Quoted 2 lines

I think this is probably the single strongest argument for sha256. "It's just there".

Yup. I actually was leaning toward saying "all of them are OK in practice, so the person who is actually spear-heading the work gets to choose", but if we picked SHA-256 now, that would not be a choice that Brian has to later justify for choosing against everybody else's wishes, which makes it the best choice ;-)

Looks like it's settled then. I thought I'd do the grunt work of updating the relevant documentation so we can officially move on from the years-long NewHash discussion.

Ævar Arnfjörð Bjarmason (2):
doc hash-function-transition: note the lack of a changelog doc hash-function-transition: pick SHA-256 as NewHash

 .../technical/hash-function-transition.txt    | 192 ++++++++++--------
 1 file changed, 102 insertions(+), 90 deletions(-)
Signature · 1 line
2.17.0.290.gded63e768a