Skip to content

drm/msm/dpu: Remove dead code

Jordan Crouse dri-devel linux-arm-msm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5drm/msm/disp/dpu: Remove unused code from drm_encoder.cdrivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h+0 -970 replies
2/5drm/msm/disp/dpu: Remove unused code from drm_crtc.cdrivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h+2 -4420 replies
3/5drm/msm/disp/dpu: Remove dpu_kms_utilsdrivers/gpu/drm/msm/Makefile drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h drivers/gpu/drm/msm/disp/dpu1/dpu_kms_utils.c+0 -2660 replies
4/5drm/msm/disp/dpu: Remove unused functions from dpu_formats.cdrivers/gpu/drm/msm/disp/dpu1/dpu_formats.c drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.c +1 more+0 -1660 replies
5/5drm/msm/disp/dpu: Mark a handful of functions as staticdrivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h +8 more+13 -470 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] drm/msm/dpu: Remove dead code

I made a silly little script that looked at the defined symbols in nm and then looked to see if other files in the module used those symbols and if they didn't they were either candidates for removal or to be made static. This is the result.

I split the code into per-file chunks for easier review and to make it easier for the developers to object to any given removal but I have no qualms if Sean or Rob want to squash these together in the final patch.

Jordan Crouse (5):
drm/msm/disp/dpu: Remove unused code from drm_encoder.c drm/msm/disp/dpu: Remove unused code from drm_crtc.c drm/msm/disp/dpu: Remove dpu_kms_utils drm/msm/disp/dpu: Remove unused functions from dpu_formats.c drm/msm/disp/dpu: Mark a handful of functions as static

 drivers/gpu/drm/msm/Makefile                  |   1 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c      | 383 +-----------------
 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h      |  61 ---
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c   |  87 +---
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h   |  14 -
 .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h  |  23 --
 .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c  |   2 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c   |  43 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_formats.h   |  48 ---
 .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c    |   2 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_cdm.c    |   4 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_top.c    |   2 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.c   |  84 ----
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_util.h   |  10 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c       |   2 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h       | 112 -----
 drivers/gpu/drm/msm/disp/dpu1/dpu_kms_utils.c | 153 -------
 drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c      |   2 +-
 18 files changed, 15 insertions(+), 1018 deletions(-)
 delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_kms_utils.c
Signature · 6 lines
2.18.0

_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno