Skip to content

Add support for PDC Global on SDM845 SoCs

Sibi Sankar linux-arm-msm linux-devicetree lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 7 repliesIn review
  2. v26 patches 12 repliesSuperseded
  3. v14 patches 17 repliesSuperseded

Changes in v3 from the cover letter

refactored pdc reset driver to remove unused layer of indirection as suggested by Matthias
Other minor fixes suggested by Matthias/Bjorn

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6dt-bindings: reset: Add PDC Global binding for SDM845 SoCsDocumentation/devicetree/bindings/reset/qcom,pdc-global.txt include/dt-bindings/reset/qcom,sdm845-pdc.h+72 -00 replies
2/6reset: qcom: PDC Global (Power Domain Controller) reset controllerdrivers/reset/Kconfig drivers/reset/Makefile drivers/reset/reset-qcom-pdc.c+134 -01 reply
3/6dt-bindings: remoteproc: qcom: Remove additional definition tagDocumentation/devicetree/bindings/remoteproc/qcom,q6v5.txt+2 -22 replies
4/6dt-bindings: remoteproc: Add PDC reset binding for Q6V5 PILDocumentation/devicetree/bindings/remoteproc/qcom,q6v5.txt+4 -00 replies
5/6remoteproc: qcom: q6v5-pil: Explicitly get mss_restart linedrivers/remoteproc/qcom_q6v5_pil.c+1 -10 replies
6/6remoteproc: qcom: q6v5-pil: Add PDC reset for modem on SDM845 SoCsdrivers/remoteproc/qcom_q6v5_pil.c+24 -50 replies

Reviews trailers per patch

4 of 6 patches have a Reviewed-by or Acked-by.

PatchBjorn AnderssonRob HerringMatthias Kaehlcke
1/6R-b R-b
2/6R-b
3/6R-b R-b R-b
4/6R-b
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/6] Add support for PDC Global on SDM845 SoCs

This patch series add support for PDC Global (Power Domain Controller) on SDM845 SoCs and adds pdc reset lines assert/deassert to remoteproc Q6v5 modem-pil. The first two patches adds PDC Global reset driver to control reset signals of Modem, Compute, Display, GPU, Debug, AOP, Sensors, Audio, SP and APPS. The last four patches (cleans up)/adds pdc reset lines to q6v5 bindings and asserts/deasserts in modem start/stop path.

V3:
refactored pdc reset driver to remove unused layer of indirection as suggested by Matthias
Other minor fixes suggested by Matthias/Bjorn

V2:
Incorporated Philipp/Bjorn/Rob suggestions Renamed reset binding to pdc-global.txt replaced offset with #define of register name replaced with devm_reset_control_get_exclusive() Separted dt binding from the drivers

Sibi Sankar (6):
dt-bindings: reset: Add PDC Global binding for SDM845 SoCs
reset: qcom: PDC Global (Power Domain Controller) reset controller
dt-bindings: remoteproc: qcom: Remove additional definition tag
dt-bindings: remoteproc: Add PDC reset binding for Q6V5 PIL
remoteproc: qcom: q6v5-pil: Explicitly get mss_restart line
remoteproc: qcom: q6v5-pil: Add PDC reset for modem on SDM845 SoCs

 .../bindings/remoteproc/qcom,q6v5.txt         |   8 +-
 .../bindings/reset/qcom,pdc-global.txt        |  52 ++++++++
 drivers/remoteproc/qcom_q6v5_pil.c            |  31 ++++-
 drivers/reset/Kconfig                         |   9 ++
 drivers/reset/Makefile                        |   1 +
 drivers/reset/reset-qcom-pdc.c                | 124 ++++++++++++++++++
 include/dt-bindings/reset/qcom,sdm845-pdc.h   |  20 +++
 7 files changed, 237 insertions(+), 8 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/reset/qcom,pdc-global.txt
 create mode 100644 drivers/reset/reset-qcom-pdc.c
 create mode 100644 include/dt-bindings/reset/qcom,sdm845-pdc.h
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project