Skip to content

staging:rtl8192u: Refactor enums r8192U_dm.h -Style

John Whitmore lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10staging:rtl8192u: Remove unused DM_check_fsync_time_interval - Styledrivers/staging/rtl8192u/r8192U_dm.h+0 -30 replies
2/10staging:rtl8192u: Refactor use of enum dm_dig_sta_e - Styledrivers/staging/rtl8192u/r8192U_dm.h+9 -92 replies
3/10staging:rtl8192u: Refactor enum dm_ratr_sta_e usage - Styledrivers/staging/rtl8192u/r8192U.h drivers/staging/rtl8192u/r8192U_dm.h+9 -90 replies
4/10staging:rtl8192u: Remove enum dm_dig_op_edrivers/staging/rtl8192u/r8192U_dm.c drivers/staging/rtl8192u/r8192U_dm.h+0 -1110 replies
5/10staging:rtl8192u: Refactor enum dm_dig_alg_e - Styledrivers/staging/rtl8192u/r8192U_dm.h+6 -70 replies
6/10staging:rtl8192u: Remove unused enum dm_dig_dbg_e - Styledrivers/staging/rtl8192u/r8192U_dm.h+0 -60 replies
7/10staging:rtl8192u: Refactor dm_dig_connect_e - Styledrivers/staging/rtl8192u/r8192U_dm.h+7 -80 replies
8/10staging:rtl8192u: Refactor enum dm_dig_pd_th_e - Styledrivers/staging/rtl8192u/r8192U_dm.h+8 -90 replies
9/10staging:rtl8192u: Refactor enum dm_dig_cs_ratio_e - Styledrivers/staging/rtl8192u/r8192U_dm.h+7 -70 replies
10/10staging:rtl8192u: Refactor enum DM_CCK_Rx_Path_Method - Styledrivers/staging/rtl8192u/r8192U_dm.h+6 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/10] staging:rtl8192u: Refactor enums r8192U_dm.h -Style

What was intended as a clean up of the file drivers/staging/rtl8192u/r8192U_dm.h turned into refactoring of most of the enumerated types defined in the file. Most of the enumerated types were simply used to define a collection of constants, rather then actually using the types as enumerated types.

So the variables which used the enums were all defined as being of type u8. This removes the ability of the compiler to do type checking of the types used. To correct this all u8 types have been changed to enums where appropriate.

Whilst I've called these patches refactoring they are all essentially coding style changes.

John Whitmore (10):
staging:rtl8192u: Remove unused DM_check_fsync_time_interval - Style staging:rtl8192u: Refactor use of enum dm_dig_sta_e - Style staging:rtl8192u: Refactor enum dm_ratr_sta_e usage - Style staging:rtl8192u: Remove enum dm_dig_op_e staging:rtl8192u: Refactor enum dm_dig_alg_e - Style staging:rtl8192u: Remove unused enum dm_dig_dbg_e - Style staging:rtl8192u: Refactor dm_dig_connect_e - Style staging:rtl8192u: Refactor enum dm_dig_pd_th_e - Style staging:rtl8192u: Refactor enum dm_dig_cs_ratio_e - Style staging:rtl8192u: Refactor enum DM_CCK_Rx_Path_Method - Style

 drivers/staging/rtl8192u/r8192U.h    |  10 ++-
 drivers/staging/rtl8192u/r8192U_dm.c |  91 -------------------
 drivers/staging/rtl8192u/r8192U_dm.h | 125 +++++++++------------------
 3 files changed, 51 insertions(+), 175 deletions(-)
Signature · 1 line
2.18.0