Skip to content

Replace ttm_bo_{unref, reference} with ttm_bo_{get|put}

Thomas Zimmermann dri-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 2 repliesIn review
  2. v11 patch 2 repliesSuperseded

Changes in v2 from the cover letter

* rebased onto drm-tip

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7drm/ast: Replace ttm_bo_unref with ttm_bo_putdrivers/gpu/drm/ast/ast_main.c+1 -50 replies
2/7drm/nouveau: Replace ttm_bo_reference with ttm_bo_getdrivers/gpu/drm/nouveau/nouveau_bo.h+6 -10 replies
3/7drm/nouveau: Replace ttm_bo_unref with ttm_bo_putdrivers/gpu/drm/nouveau/nouveau_bo.h drivers/gpu/drm/nouveau/nouveau_gem.c+3 -70 replies
4/7drm/vmwgfx: Replace ttm_bo_reference with ttm_bo_getdrivers/gpu/drm/vmwgfx/vmwgfx_bo.c drivers/gpu/drm/vmwgfx/vmwgfx_drv.h drivers/gpu/drm/vmwgfx/vmwgfx_resource.c+7 -60 replies
5/7drm/vmwgfx: Replace ttm_bo_unref with ttm_bo_putdrivers/gpu/drm/vmwgfx/vmwgfx_bo.c drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c drivers/gpu/drm/vmwgfx/vmwgfx_drv.h +3 more+32 -240 replies
6/7drm/mgag200: Replace ttm_bo_unref with ttm_bo_putdrivers/gpu/drm/mgag200/mgag200_main.c+2 -60 replies
7/7drm/ttm: Remove ttm_bo_reference and ttm_bo_unrefdrivers/gpu/drm/ttm/ttm_bo.c include/drm/ttm/ttm_bo_api.h+0 -370 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchChristian KönigHuang Rui
SeriesR-b R-b
1/7
2/7
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/7] Replace ttm_bo_{unref, reference} with ttm_bo_{get|put}

This patchset cleans up the last remaining callers of ttm_bo_reference and ttm_bo_unref. Calls are replaced with ttm_bo_get and ttm_bo_put, which follow Linux' get/put semantics more closely.

The most notable difference is that ttm_bo_get does not clear the supplied pointer's value. This behaviour is now located in the calling code for cases where it might be required.

v2:
* rebased onto drm-tip

Thomas Zimmermann (7):
drm/ast: Replace ttm_bo_unref with ttm_bo_put drm/nouveau: Replace ttm_bo_reference with ttm_bo_get drm/nouveau: Replace ttm_bo_unref with ttm_bo_put drm/vmwgfx: Replace ttm_bo_reference with ttm_bo_get drm/vmwgfx: Replace ttm_bo_unref with ttm_bo_put drm/mgag200: Replace ttm_bo_unref with ttm_bo_put drm/ttm: Remove ttm_bo_reference and ttm_bo_unref

 drivers/gpu/drm/ast/ast_main.c             |  6 +----
 drivers/gpu/drm/mgag200/mgag200_main.c     |  8 ++-----
 drivers/gpu/drm/nouveau/nouveau_bo.h       | 12 ++++++----
 drivers/gpu/drm/nouveau/nouveau_gem.c      |  3 +--
 drivers/gpu/drm/ttm/ttm_bo.c               |  9 -------
 drivers/gpu/drm/vmwgfx/vmwgfx_bo.c         | 11 ++++-----
 drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c     | 11 +++++----
 drivers/gpu/drm/vmwgfx/vmwgfx_drv.h        |  9 +++----
 drivers/gpu/drm/vmwgfx/vmwgfx_mob.c        | 21 ++++++++++------
 drivers/gpu/drm/vmwgfx/vmwgfx_resource.c   |  9 ++++---
 drivers/gpu/drm/vmwgfx/vmwgfx_validation.c |  6 +++--
 include/drm/ttm/ttm_bo_api.h               | 28 ----------------------
 12 files changed, 49 insertions(+), 84 deletions(-)
Signature · 6 lines
2.20.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel