minicom: update to use latest git repository
Get series with b4
b4 am 20180801190033.436cc1b2@windsurfVersions newest first
- v1 Latest0 of 4 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 4 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [Buildroot] [PATCH 0/4] minicom: update to use latest git repository
Hello,
Quoted 10 lines · Giulio Benetti
Quoted 8 lines
Quoted 5 lines
Giulio Benetti (4):
minicom: update package to use git repository.
minicom: add pre-configure hook to callautogen.sh
minicom: delete patches
minicom: delete hash file.All these patches should be just one, otherwise your series is not bisectable.
Ah ok, I thought it was easier break all patches.
It's not about being "easy". It's about separating logical changes, one per patch.
Here the problem of your patch series is that if I apply just PATCH 1/4, minicom no longer builds, because it doesn't do the autoreconf tweak, the patches won't apply, and the hash file doesn't match. This is why I said your series is "not bisectable": it doesn't build/work between each patch of the series.
In your situation, the change to use this different download location for Minicom is the change, and as part of the change, it is necessary to remove patches, tweak for autoreconf and delete the hash file. This is all one change.
Quoted 1 line
So basically the commit log will be the cover letter, right?
Yes.
Quoted 1 line
And btw, is commit log of cover letter acceptable?
There is no "commit log" in the cover letter. The commit logs are in the patches themselves. The cover letter contains some introduction text, and is only necessary for patch series with multiple patches, for which additional explanations about what the whole series is doing.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com