Skip to content

staging:rtl8192u: Clean up ofr8192U_dm.h

John Whitmore lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18staging:rtl8192u: Remove debug member from structures - Styledrivers/staging/rtl8192u/r8192U_dm.c drivers/staging/rtl8192u/r8192U_dm.h+2 -140 replies
2/18staging:rtl8192u: Remove member variable rx_gain_range_max - Styledrivers/staging/rtl8192u/r8192U_dm.c drivers/staging/rtl8192u/r8192U_dm.h+2 -40 replies
3/18staging:rtl8192u: Remove member initialgain_lowerbound_state - Styledrivers/staging/rtl8192u/r8192U_dm.c drivers/staging/rtl8192u/r8192U_dm.h+0 -20 replies
4/18staging:rtl8192u: Rename enum constants - Styledrivers/staging/rtl8192u/r8192U_dm.c drivers/staging/rtl8192u/r8192U_dm.h+8 -80 replies
5/18staging:rtl8192u: Remove unused extern DM_RxPathSelTable - Styledrivers/staging/rtl8192u/r8192U_dm.c drivers/staging/rtl8192u/r8192U_dm.h+1 -20 replies
6/18staging:rtl8192u: Remove member variable Enable - Styledrivers/staging/rtl8192u/r8192U_dm.c drivers/staging/rtl8192u/r8192U_dm.h+0 -40 replies
7/18staging:rtl8192u: Rename cck_Rx_path - Styledrivers/staging/rtl8192u/r8192U_dm.c drivers/staging/rtl8192u/r8192U_dm.h+5 -50 replies
8/18staging:rtl8192u: Remove SS_TH_low - Styledrivers/staging/rtl8192u/r8192U_dm.c drivers/staging/rtl8192u/r8192U_dm.h+2 -40 replies
9/18staging:rtl8192u: Remove member diff_TH - Styledrivers/staging/rtl8192u/r8192U_dm.c drivers/staging/rtl8192u/r8192U_dm.h+2 -40 replies
10/18staging:rtl8192u: Rename member disabledRF - Styledrivers/staging/rtl8192u/r8192U_dm.c drivers/staging/rtl8192u/r8192U_dm.h+6 -60 replies
11/18staging:rtl8192u: Remove member reserved - Styledrivers/staging/rtl8192u/r8192U_dm.h+0 -10 replies
12/18staging:rtl8192u: Refactor DCMD_TXCMD_T structure - Styledrivers/staging/rtl8192u/r8192U_dm.c drivers/staging/rtl8192u/r8192U_dm.h+11 -100 replies
13/18staging:rtl8192u: Rename DM_DIG_MIN_Netcore - Styledrivers/staging/rtl8192u/r8192U_dm.c drivers/staging/rtl8192u/r8192U_dm.h+2 -20 replies
14/18staging:rtl8192u: Rename RateAdaptiveTH_High - Styledrivers/staging/rtl8192u/r8192U_core.c drivers/staging/rtl8192u/r8192U_dm.c drivers/staging/rtl8192u/r8192U_dm.h+5 -50 replies
15/18staging:rtl8192u: Rename constants RateAdaptiveTH_Low_* - Styledrivers/staging/rtl8192u/r8192U_core.c drivers/staging/rtl8192u/r8192U_dm.c drivers/staging/rtl8192u/r8192U_dm.h+10 -100 replies
16/18staging:rtl8192u: Rename constants - Styledrivers/staging/rtl8192u/r8192U_core.c drivers/staging/rtl8192u/r8192U_dm.c drivers/staging/rtl8192u/r8192U_dm.h+4 -40 replies
17/18staging:rtl8192u: Rename Register Constants - Styledrivers/staging/rtl8192u/r8192U_dm.c drivers/staging/rtl8192u/r8192U_dm.h+12 -120 replies
18/18staging:rtl8192u: Clean up of spacing - Styledrivers/staging/rtl8192u/r8192U_dm.h+58 -650 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/18] staging:rtl8192u: Clean up ofr8192U_dm.h

This series of patches is a clean up of the file:
drivers/staging/rtl8192u/r8192U_dm.h

Whilst I consider all the changes to be coding style changes some have removed structure member variables which were not implementing any logic, which required them to be a member of a structure. The first patch removes member variables from two separate structures which seem to have been intended to add functionality for debugging. Whether that feature was forgotten about I'm not sure but as it serves no purpose both member variables were removed.

I hope I've not missed something

John Whitmore (18):
staging:rtl8192u: Remove debug member from structures - Style staging:rtl8192u: Remove member variable rx_gain_range_max - Style staging:rtl8192u: Remove member initialgain_lowerbound_state - Style staging:rtl8192u: Rename enum constants - Style staging:rtl8192u: Remove unused extern DM_RxPathSelTable - Style staging:rtl8192u: Remove member variable Enable - Style staging:rtl8192u: Rename cck_Rx_path - Style staging:rtl8192u: Remove SS_TH_low - Style staging:rtl8192u: Remove member diff_TH - Style staging:rtl8192u: Rename member disabledRF - Style staging:rtl8192u: Remove member reserved - Style staging:rtl8192u: Refactor DCMD_TXCMD_T structure - Style staging:rtl8192u: Rename DM_DIG_MIN_Netcore - Style staging:rtl8192u: Rename RateAdaptiveTH_High - Style staging:rtl8192u: Rename constants RateAdaptiveTH_Low_* - Style staging:rtl8192u: Rename constants - Style staging:rtl8192u: Rename Register Constants - Style staging:rtl8192u: Clean up of spacing - Style

 drivers/staging/rtl8192u/r8192U_core.c |  14 +--
 drivers/staging/rtl8192u/r8192U_dm.c   |  97 +++++++---------
 drivers/staging/rtl8192u/r8192U_dm.h   | 151 +++++++++++--------------
 3 files changed, 115 insertions(+), 147 deletions(-)
Signature · 1 line
2.18.0