Skip to content

perf annotate: Make symbol__annotate_fprintf2 local

Jiri Olsa lkml 1 version Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest20 patches 26 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/20perf annotate: Make symbol__annotate_fprintf2 localtools/perf/util/annotate.c tools/perf/util/annotate.h+1 -21 reply
2/20perf annotate: Make annotation_line__max_percent statictools/perf/util/annotate.c tools/perf/util/annotate.h+2 -21 reply
3/20perf annotate: Get rid of annotation__scnprintf_samples_periodtools/perf/ui/browsers/annotate.c tools/perf/util/annotate.c tools/perf/util/annotate.h+3 -511 reply
4/20perf annotate: Rename struct annotation_line::samples* to data*tools/perf/ui/browsers/annotate.c tools/perf/util/annotate.c tools/perf/util/annotate.h+33 -331 reply
5/20perf annotate: Rename local sample variables to datatools/perf/util/annotate.c+20 -201 reply
6/20perf annotate: Rename hist to sym_hist in annotation__calc_percenttools/perf/util/annotate.c+8 -81 reply
7/20perf annotate: Loop group events directly in annotation__calc_percenttools/perf/util/annotate.c tools/perf/util/evsel.h+15 -51 reply
8/20perf annotate: Switch struct annotation_data::percent to arraytools/perf/ui/browsers/annotate.c tools/perf/util/annotate.c tools/perf/util/annotate.h+56 -231 reply
9/20perf annotate: Add PERCENT_HITS_GLOBAL percent valuetools/perf/util/annotate.c tools/perf/util/annotate.h+8 -11 reply
10/20perf annotate: Add PERCENT_PERIOD_LOCAL percent valuetools/perf/util/annotate.c tools/perf/util/annotate.h+3 -01 reply
11/20perf annotate: Add PERCENT_PERIOD_GLOBAL percent valuetools/perf/util/annotate.c tools/perf/util/annotate.h+4 -01 reply
12/20perf annotate: Add percent_type to struct annotation_optionstools/perf/util/annotate.c tools/perf/util/annotate.h+9 -51 reply
13/20perf annotate: Pass struct annotation_options to symbol__calc_linestools/perf/util/annotate.c+13 -101 reply
14/20perf annotate: Pass struct annotation_options to map_symbol__annotation_dumptools/perf/ui/browsers/annotate.c tools/perf/util/annotate.c tools/perf/util/annotate.h+29 -234 replies
15/20perf annotate: Pass browser percent_type in annotate_browser__calc_percenttools/perf/ui/browsers/annotate.c+1 -11 reply
16/20perf annotate: Add support to togle percent typetools/perf/ui/browsers/annotate.c tools/perf/util/annotate.h+68 -51 reply
17/20perf annotate: Make local period the default percent typetools/perf/util/annotate.c+1 -11 reply
18/20perf annotate: Display percent type in stdio outputtools/perf/util/annotate.c+6 -31 reply
19/20perf annotate: Add --percent-type optiontools/perf/Documentation/perf-annotate.txt tools/perf/builtin-annotate.c tools/perf/util/annotate.c +1 more+69 -04 replies
20/20perf report: Add --percent-type optiontools/perf/Documentation/perf-report.txt tools/perf/builtin-report.c+12 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/20] perf annotate: Make symbol__annotate_fprintf2 local

hi,
Stephane asked for key/option switch between local/global percentage in annotation output/browser [1]. Local means % within symbol, global within the whole perf data.

Adding the support to specify this by new --precent-type option added for perf annotate and report.

Also adding 'p' key binding to annotation browser to change between local/global percentages.

Also available in:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
perf/fixes

thanks,
jirka

[1] https://marc.info/?l=linux-kernel&m=153195093118669&w=2

---
Jiri Olsa (20):
perf annotate: Make symbol__annotate_fprintf2 local
perf annotate: Make annotation_line__max_percent static
perf annotate: Get rid of annotation__scnprintf_samples_period perf annotate: Rename struct annotation_line::samples* to data* perf annotate: Rename local sample variables to data
perf annotate: Rename hist to sym_hist in annotation__calc_percent perf annotate: Loop group events directly in annotation__calc_percent perf annotate: Switch struct annotation_data::percent to array perf annotate: Add PERCENT_HITS_GLOBAL percent value
perf annotate: Add PERCENT_PERIOD_LOCAL percent value
perf annotate: Add PERCENT_PERIOD_GLOBAL percent value
perf annotate: Add percent_type to struct annotation_options perf annotate: Pass struct annotation_options to symbol__calc_lines perf annotate: Pass struct annotation_options to map_symbol__annotation_dump perf annotate: Pass browser percent_type in annotate_browser__calc_percent perf annotate: Add support to togle percent type
perf annotate: Make local period the default percent type
perf annotate: Display percent type in stdio output
perf annotate: Add --percent-type option
perf report: Add --percent-type option

 tools/perf/Documentation/perf-annotate.txt |   9 ++++
 tools/perf/Documentation/perf-report.txt   |   9 ++++
 tools/perf/builtin-annotate.c              |   4 ++
 tools/perf/builtin-report.c                |   3 ++
 tools/perf/ui/browsers/annotate.c          |  81 +++++++++++++++++++++++++-------
 tools/perf/util/annotate.c                 | 302 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------------------------
 tools/perf/util/annotate.h                 |  55 ++++++++++++++++------
 tools/perf/util/evsel.h                    |   7 +++
 8 files changed, 319 insertions(+), 151 deletions(-)