perf/hw_breakpoint: Fix breakpoint modify
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest5 patches 1 replyIn review
- v35 patches 6 repliesSuperseded
- v25 patches 7 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 2 patches | 12 replies | Superseded |
Changes in v4 from the cover letter
- added Oleg's and Frederic's acks
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | perf tests: Add breakpoint modify teststools/ tools/ tools/ +1 more | +221 | 0 replies | |
| 2/5 | perf/hw_breakpoint: Modify breakpoint even if the new attr has disabled setkernel/ | +6 | 0 replies | |
| 3/5 | perf/hw_breakpoint: Remove superfluous bp->attr.disabled = 0kernel/ | +2 | 0 replies | |
| 4/5 | perf/hw_breakpoint: Enable breakpoint in modify_user_hw_breakpointkernel/ | +2 | 0 replies | |
| 5/5 | perf/hw_breakpoint: Simplify breakpoint enable in perf_event_modify_breakpointkernel/ | +3 | 0 replies |
Reviews trailers per patch
4 of 5 patches have a Reviewed-by or Acked-by.
| Patch | Oleg Nesterov | Frederic Weisbecker |
|---|---|---|
| 1/5 | ||
| 2/5 | A-b | A-b |
| 3/5 | A-b | A-b |
| 4/5 | A-b | A-b |
| 5/5 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCHv4 0/5] perf/hw_breakpoint: Fix breakpoint modify
hi,
Milind reported that modify_user_hw_breakpoint wouldn't allow the breakpoint changing if the new attr had 'disabled' set to true.
I found a case where it actualy prevents ptrace user interface to change the breakpoint. It's described in patch 1 as perf test, patch 2 is the breakpoint code fix.
I ran strace tests, nothing (new) broken there..
v4 changes:
- added Oleg's and Frederic's acks
v3 changes:
- added Oleg's ack for patch 3
- new patches 4,5 based on Oleg's suggestions replacing the v2 fallback approach by enabling the event directly after failed modification
v2 changes:
- added Oleg's ack for patch 2
- added new changes based on Oleg's questions
plus new test code
thanks,
jirka
---
Jiri Olsa (5):
perf tests: Add breakpoint modify tests
perf/hw_breakpoint: Modify breakpoint even if the new attr has disabled set perf/hw_breakpoint: Remove superfluous bp->attr.disabled = 0 perf/hw_breakpoint: Enable breakpoint in modify_user_hw_breakpoint perf/hw_breakpoint: Simplify breakpoint enable in perf_event_modify_breakpoint
kernel/events/core.c | 11 ++----- kernel/events/hw_breakpoint.c | 13 ++++---- tools/perf/arch/x86/include/arch-tests.h | 1 + tools/perf/arch/x86/tests/Build | 1 + tools/perf/arch/x86/tests/arch-tests.c | 6 ++++ tools/perf/arch/x86/tests/bp-modify.c | 213 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 6 files changed, 230 insertions(+), 15 deletions(-) create mode 100644 tools/perf/arch/x86/tests/bp-modify.c