Skip to content

bme680 cleanup

David Frey linux-iio 3 versions – Applied

Status from this message: Applied,

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 23 repliesApplied
  2. v27 patches 4 repliesSuperseded
  3. v12 patches 2 repliesSuperseded

Changes in v3 from the cover letter

- Added "MSK->MASK" patch hunk accidentally omitted from v2
- Applied Himanshu's "iio: chemical: bme680: Add check for val2 in the write_raw function" patch on top of jic23/iio rev 5e45729608dd before rebasing this patch series on top.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/7iio: chemical: bme680: use clamp macrodrivers/iio/chemical/bme680_core.c+1 -45 replies
2/7iio: chemical: bme680: cleanup bme680_read_calib formattingdrivers/iio/chemical/bme680_core.c+12 -245 replies
3/7iio: chemical: bme680: indent #defines consistentlydrivers/iio/chemical/bme680.h+7 -88 replies
4/7iio: chemical: bme680: change MSK->MASK in #definesdrivers/iio/chemical/bme680.h drivers/iio/chemical/bme680_core.c+6 -62 replies
5/7iio: chemical: bme680: use GENMASK macrodrivers/iio/chemical/bme680.h+4 -42 replies
6/7iio: chemical: bme680: use FIELD_GET macrodrivers/iio/chemical/bme680_core.c+2 -22 replies
7/7iio: chemical: bme680: simplify oversampling handlingdrivers/iio/chemical/bme680_core.c+36 -632 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchHimanshu Jha
1/7R-b T-b
2/7R-b T-b
3/7R-b T-b R-b T-b
4/7R-b T-b
5/7R-b T-b
6/7R-b T-b
7/7R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/7] bme680 cleanup

v3:
- Added "MSK->MASK" patch hunk accidentally omitted from v2
- Applied Himanshu's "iio: chemical: bme680: Add check for val2 in the write_raw function" patch on top of jic23/iio rev 5e45729608dd before rebasing this patch series on top.

v2:
This version addresses Himanshu's feedback
- split v1 patch 1 into 6 commits
- substantially changed "simplify oversampling handling" after review identified a bug in the previous patch version and I spent some more time thinking about the problem

v1:
I have performed some minor cleanup on the bme680 driver. I don't think there's anything controversial in my changes. Let me know what you think

David Frey (7):
iio: chemical: bme680: use clamp macro
iio: chemical: bme680: cleanup bme680_read_calib formatting
iio: chemical: bme680: indent #defines consistently
iio: chemical: bme680: change MSK->MASK in #defines
iio: chemical: bme680: use GENMASK macro
iio: chemical: bme680: use FIELD_GET macro
iio: chemical: bme680: simplify oversampling handling

 drivers/iio/chemical/bme680.h      |  17 +++--
 drivers/iio/chemical/bme680_core.c | 144 +++++++++++++------------------------
 2 files changed, 59 insertions(+), 102 deletions(-)
Signature · 1 line
2.11.0