RFC tools lib traceevent: Rename pevent to tep for preparation for library
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 RFC Latest24 patches 2 repliesIn review
- v1 RFC24 patches 11 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/24 | tools/lib/traceevent, tools/perf: Rename struct pevent to struct tep_handletools/ tools/ tools/ +21 more | +215 | 0 replies | |
| 2/24 | tools/lib/traceevent, tools/perf: Rename struct pevent_record to struct tep_recordtools/ tools/ tools/ +9 more | +70 | 0 replies | |
| 3/24 | tools/lib/traceevent, tools/perf: Rename pevent plugin related APIstools/ tools/ tools/ +10 more | +67 | 0 replies | |
| 4/24 | tools/lib/traceevent, tools/perf: Rename pevent alloc / free APIstools/ tools/ tools/ +4 more | +25 | 0 replies | |
| 5/24 | tools/lib/traceevent, tools/perf: Rename pevent find APIstools/ tools/ tools/ +9 more | +57 | 0 replies | |
| 6/24 | tools/lib/traceevent, tools/perf: Rename pevent parse APIstools/ tools/ tools/ +2 more | +25 | 0 replies | |
| 7/24 | tools/lib/traceevent, tools/perf: Rename pevent print APIstools/ tools/ tools/ +4 more | +89 | 0 replies | |
| 8/24 | tools/lib/traceevent, tools/perf: Rename pevent_read_number_* APIstools/ tools/ tools/ +7 more | +52 | 0 replies | |
| 9/24 | tools/lib/traceevent, tools/perf: Rename pevent_register_* APIstools/ tools/ tools/ +1 more | +11 | 0 replies | |
| 10/24 | tools/lib/traceevent, tools/perf: Rename pevent_set_* APIstools/ tools/ tools/ +4 more | +29 | 0 replies | |
| 11/24 | tools/lib/traceevent, tools/perf: Rename traceevent_* APIstools/ tools/ tools/ | +11 | 0 replies | |
| 12/24 | tools/lib/traceevent, tools/perf: Rename enum pevent_flag to enum tep_flagtools/ tools/ tools/ +3 more | +11 | 0 replies | |
| 13/24 | tools/lib/traceevent, tools/lib/lockdep/: Rename enunm pevent_errno to enum tep_errnotools/ tools/ tools/ +2 more | +133 | 0 replies | |
| 14/24 | tools/lib/traceevent: Rename pevent_function* APIstools/ tools/ tools/ +4 more | +66 | 0 replies | |
| 15/24 | tools/lib/traceevent, tools/perf: Rename traceevent_plugin_* APIstools/ tools/ tools/ | +24 | 0 replies | |
| 16/24 | tools/lib/traceevent: Rename pevent_filter* APIstools/ tools/ | +67 | 0 replies | |
| 17/24 | tools/lib/traceevent: Rename pevent_register / unregister APIstools/ tools/ tools/ +9 more | +179 | 0 replies | |
| 18/24 | tools/lib/traceevent: Rename pevent_data_ APIstools/ tools/ tools/ | +36 | 0 replies | |
| 19/24 | tools/lib/traceevent: Rename pevent field APIstools/ tools/ tools/ +2 more | +60 | 0 replies | |
| 20/24 | tools/lib/traceevent: Rename pevent_find_* APIstools/ tools/ tools/ +2 more | +25 | 0 replies | |
| 21/24 | tools/lib/traceevent: Rename various pevent get/set/is APIstools/ tools/ tools/ | +11 | 2 replies | |
| 22/24 | tools/lib/traceevent: Rename internal parser related APIstools/ tools/ tools/ | +26 | 0 replies | |
| 23/24 | tools/lib/traceevent: Rename various pevent APIstools/ tools/ tools/ | +21 | 0 replies | |
| 24/24 | tools/lib/traceevent: Rename static variables and functions in event-parse.ctools/ | +27 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [RFC][PATCH v2 00/24] tools lib traceevent: Rename pevent to tep for preparation for library
[
Resending as quilt mail threading was broken, but luckily was fixed by
http://git.savannah.nongnu.org/cgit/quilt.git/commit/?id=360b85e1f6b6d1aff5ada942fcee816e1ad7a13c
And has been reported to Debian:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=900784
]
Having libtraceevent turn into a proper library has long been asked for. I never had time to do it before. Luckily, Tzvetomir was able to spend the time to start the preparation. The first thing that needs to be done is to handle namespace collisions. "pevent" was the prefix I chose, but many people were displeased by it, as it didn't express what the functions were used for. After discussing with many people at many conferences I've come up with "tep", which means "Trace Event Parser". Please don't question this. The bikeshed has been painted and I'm not changing the color.
This series changes all the function names and data structures from the "pevent_" prefix to the "tep_" prefix. Note, it does not change the names of local variables or even parameters. "pevent" variables and parameters still exist. We can change those later, but for now, I want all global references to "pevent" to be "tep_" instead.
This is not complete. It is only one of many preparations to make libtraceevent into a legitimate library. There's other naming conventions that will be made. But for now, I would like to hear thoughts about this change before we proceed further.
Instead of doing one big update, Tzvetomir grouped changes together. I compiled each patch to make sure perf still builds without errors at each step. I only used my own configuration, thus there may be cases that perf might fail to build. Here's what I had:
Auto-detecting system features:
... dwarf: [ on ] ... dwarf_getlocations: [ on ] ... glibc: [ on ] ... gtk2: [ on ] ... libaudit: [ OFF ] ... libbfd: [ on ] ... libelf: [ on ]
... libnuma: [ OFF ]
... numa_num_possible_cpus: [ OFF ]
... libperl: [ OFF ]
... libpython: [ on ]
... libslang: [ OFF ]
... libcrypto: [ on ]
... libunwind: [ OFF ]
... libdw-dwarf-unwind: [ on ] ... zlib: [ on ] ... lzma: [ on ] ... get_cpuid: [ on ] ... bpf: [ on ]
The above is the config I used for testing the build.
-- Steve
Tzvetomir Stoyanov (VMware) (24):
tools/lib/traceevent, tools/perf: Rename struct pevent to struct tep_handle tools/lib/traceevent, tools/perf: Rename struct pevent_record to struct tep_record tools/lib/traceevent, tools/perf: Rename pevent plugin related APIs tools/lib/traceevent, tools/perf: Rename pevent alloc / free APIs tools/lib/traceevent, tools/perf: Rename pevent find APIs tools/lib/traceevent, tools/perf: Rename pevent parse APIs tools/lib/traceevent, tools/perf: Rename pevent print APIs tools/lib/traceevent, tools/perf: Rename pevent_read_number_* APIs tools/lib/traceevent, tools/perf: Rename pevent_register_* APIs tools/lib/traceevent, tools/perf: Rename pevent_set_* APIs tools/lib/traceevent, tools/perf: Rename traceevent_* APIs tools/lib/traceevent, tools/perf: Rename enum pevent_flag to enum tep_flag tools/lib/traceevent, tools/lib/lockdep/: Rename enunm pevent_errno to enum tep_errno tools/lib/traceevent: Rename pevent_function* APIs tools/lib/traceevent, tools/perf: Rename traceevent_plugin_* APIs tools/lib/traceevent: Rename pevent_filter* APIs
tools/lib/traceevent: Rename pevent_register / unregister APIs tools/lib/traceevent: Rename pevent_data_ APIs
tools/lib/traceevent: Rename pevent field APIs
tools/lib/traceevent: Rename pevent_find_* APIs
tools/lib/traceevent: Rename various pevent get/set/is APIs tools/lib/traceevent: Rename internal parser related APIs tools/lib/traceevent: Rename various pevent APIs
tools/lib/traceevent: Rename static variables and functions in event-parse.c
----
tools/lib/lockdep/Makefile | 4 +- tools/lib/traceevent/Makefile | 4 +- tools/lib/traceevent/event-parse.c | 696 ++++++++++----------- tools/lib/traceevent/event-parse.h | 458 +++++++------- tools/lib/traceevent/event-plugin.c | 70 +-- tools/lib/traceevent/parse-filter.c | 288 ++++----- tools/lib/traceevent/plugin_cfg80211.c | 20 +- tools/lib/traceevent/plugin_function.c | 34 +- tools/lib/traceevent/plugin_hrtimer.c | 56 +- tools/lib/traceevent/plugin_jbd2.c | 36 +- tools/lib/traceevent/plugin_kmem.c | 66 +- tools/lib/traceevent/plugin_kvm.c | 154 ++--- tools/lib/traceevent/plugin_mac80211.c | 28 +- tools/lib/traceevent/plugin_sched_switch.c | 60 +- tools/lib/traceevent/plugin_scsi.c | 24 +- tools/lib/traceevent/plugin_xen.c | 20 +- tools/perf/builtin-kmem.c | 6 +- tools/perf/builtin-report.c | 6 +- tools/perf/builtin-script.c | 6 +- tools/perf/util/data-convert-bt.c | 6 +- tools/perf/util/evsel.c | 2 +- tools/perf/util/header.c | 6 +- tools/perf/util/machine.h | 2 +- tools/perf/util/python.c | 10 +- .../perf/util/scripting-engines/trace-event-perl.c | 2 +- .../util/scripting-engines/trace-event-python.c | 6 +- tools/perf/util/sort.c | 16 +- tools/perf/util/sort.h | 2 +- tools/perf/util/trace-event-parse.c | 34 +- tools/perf/util/trace-event-read.c | 44 +- tools/perf/util/trace-event-scripting.c | 4 +- tools/perf/util/trace-event.c | 28 +- tools/perf/util/trace-event.h | 20 +- 33 files changed, 1109 insertions(+), 1109 deletions(-)