Skip to content

RFC tools lib traceevent: Rename pevent to tep for preparation for library

Steven Rostedt linux-trace-devel lkml 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 RFC Latest24 patches 2 repliesIn review
  2. v1 RFC24 patches 11 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/24tools/lib/traceevent, tools/perf: Rename struct pevent to struct tep_handletools/lib/traceevent/event-parse.c tools/lib/traceevent/event-parse.h tools/lib/traceevent/event-plugin.c +21 more+215 -2150 replies
2/24tools/lib/traceevent, tools/perf: Rename struct pevent_record to struct tep_recordtools/lib/traceevent/event-parse.c tools/lib/traceevent/event-parse.h tools/lib/traceevent/parse-filter.c +9 more+70 -700 replies
3/24tools/lib/traceevent, tools/perf: Rename pevent plugin related APIstools/lib/traceevent/event-parse.c tools/lib/traceevent/event-parse.h tools/lib/traceevent/event-plugin.c +10 more+67 -670 replies
4/24tools/lib/traceevent, tools/perf: Rename pevent alloc / free APIstools/lib/traceevent/event-parse.c tools/lib/traceevent/event-parse.h tools/perf/builtin-kmem.c +4 more+25 -250 replies
5/24tools/lib/traceevent, tools/perf: Rename pevent find APIstools/lib/traceevent/event-parse.c tools/lib/traceevent/event-parse.h tools/lib/traceevent/parse-filter.c +9 more+57 -570 replies
6/24tools/lib/traceevent, tools/perf: Rename pevent parse APIstools/lib/traceevent/event-parse.c tools/lib/traceevent/event-parse.h tools/perf/util/trace-event-parse.c +2 more+25 -250 replies
7/24tools/lib/traceevent, tools/perf: Rename pevent print APIstools/lib/traceevent/event-parse.c tools/lib/traceevent/event-parse.h tools/lib/traceevent/plugin_hrtimer.c +4 more+89 -890 replies
8/24tools/lib/traceevent, tools/perf: Rename pevent_read_number_* APIstools/lib/traceevent/event-parse.c tools/lib/traceevent/event-parse.h tools/lib/traceevent/parse-filter.c +7 more+52 -520 replies
9/24tools/lib/traceevent, tools/perf: Rename pevent_register_* APIstools/lib/traceevent/event-parse.c tools/lib/traceevent/event-parse.h tools/lib/traceevent/plugin_sched_switch.c +1 more+11 -110 replies
10/24tools/lib/traceevent, tools/perf: Rename pevent_set_* APIstools/lib/traceevent/event-parse.c tools/lib/traceevent/event-parse.h tools/perf/builtin-report.c +4 more+29 -290 replies
11/24tools/lib/traceevent, tools/perf: Rename traceevent_* APIstools/lib/traceevent/event-parse.h tools/lib/traceevent/event-plugin.c tools/perf/util/trace-event.c+11 -110 replies
12/24tools/lib/traceevent, tools/perf: Rename enum pevent_flag to enum tep_flagtools/lib/traceevent/event-parse.c tools/lib/traceevent/event-parse.h tools/lib/traceevent/event-plugin.c +3 more+11 -110 replies
13/24tools/lib/traceevent, tools/lib/lockdep/: Rename enunm pevent_errno to enum tep_errnotools/lib/lockdep/Makefile tools/lib/traceevent/Makefile tools/lib/traceevent/event-parse.c +2 more+133 -1330 replies
14/24tools/lib/traceevent: Rename pevent_function* APIstools/lib/traceevent/event-parse.c tools/lib/traceevent/event-parse.h tools/lib/traceevent/plugin_cfg80211.c +4 more+66 -660 replies
15/24tools/lib/traceevent, tools/perf: Rename traceevent_plugin_* APIstools/lib/traceevent/event-parse.h tools/lib/traceevent/event-plugin.c tools/lib/traceevent/plugin_function.c+24 -240 replies
16/24tools/lib/traceevent: Rename pevent_filter* APIstools/lib/traceevent/event-parse.h tools/lib/traceevent/parse-filter.c+67 -670 replies
17/24tools/lib/traceevent: Rename pevent_register / unregister APIstools/lib/traceevent/event-parse.c tools/lib/traceevent/event-parse.h tools/lib/traceevent/plugin_cfg80211.c +9 more+179 -1790 replies
18/24tools/lib/traceevent: Rename pevent_data_ APIstools/lib/traceevent/event-parse.c tools/lib/traceevent/event-parse.h tools/lib/traceevent/parse-filter.c+36 -360 replies
19/24tools/lib/traceevent: Rename pevent field APIstools/lib/traceevent/event-parse.c tools/lib/traceevent/event-parse.h tools/lib/traceevent/plugin_function.c +2 more+60 -600 replies
20/24tools/lib/traceevent: Rename pevent_find_* APIstools/lib/traceevent/event-parse.c tools/lib/traceevent/event-parse.h tools/lib/traceevent/parse-filter.c +2 more+25 -250 replies
21/24tools/lib/traceevent: Rename various pevent get/set/is APIstools/lib/traceevent/event-parse.c tools/lib/traceevent/event-parse.h tools/lib/traceevent/plugin_kvm.c+11 -112 replies
22/24tools/lib/traceevent: Rename internal parser related APIstools/lib/traceevent/event-parse.c tools/lib/traceevent/event-parse.h tools/lib/traceevent/parse-filter.c+26 -260 replies
23/24tools/lib/traceevent: Rename various pevent APIstools/lib/traceevent/event-parse.c tools/lib/traceevent/event-parse.h tools/lib/traceevent/parse-filter.c+21 -210 replies
24/24tools/lib/traceevent: Rename static variables and functions in event-parse.ctools/lib/traceevent/event-parse.c+27 -270 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [RFC][PATCH v2 00/24] tools lib traceevent: Rename pevent to tep for preparation for library

[
Resending as quilt mail threading was broken, but luckily was fixed by
http://git.savannah.nongnu.org/cgit/quilt.git/commit/?id=360b85e1f6b6d1aff5ada942fcee816e1ad7a13c
And has been reported to Debian:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=900784
]

Having libtraceevent turn into a proper library has long been asked for. I never had time to do it before. Luckily, Tzvetomir was able to spend the time to start the preparation. The first thing that needs to be done is to handle namespace collisions. "pevent" was the prefix I chose, but many people were displeased by it, as it didn't express what the functions were used for. After discussing with many people at many conferences I've come up with "tep", which means "Trace Event Parser". Please don't question this. The bikeshed has been painted and I'm not changing the color.

This series changes all the function names and data structures from the "pevent_" prefix to the "tep_" prefix. Note, it does not change the names of local variables or even parameters. "pevent" variables and parameters still exist. We can change those later, but for now, I want all global references to "pevent" to be "tep_" instead.

This is not complete. It is only one of many preparations to make libtraceevent into a legitimate library. There's other naming conventions that will be made. But for now, I would like to hear thoughts about this change before we proceed further.

Instead of doing one big update, Tzvetomir grouped changes together. I compiled each patch to make sure perf still builds without errors at each step. I only used my own configuration, thus there may be cases that perf might fail to build. Here's what I had:

Auto-detecting system features:

...                         dwarf: [ on  ]
...            dwarf_getlocations: [ on  ]
...                         glibc: [ on  ]
...                          gtk2: [ on  ]
...                      libaudit: [ OFF ]
...                        libbfd: [ on  ]
...                        libelf: [ on  ]

... libnuma: [ OFF ]
... numa_num_possible_cpus: [ OFF ]
... libperl: [ OFF ]
... libpython: [ on ]
... libslang: [ OFF ]
... libcrypto: [ on ]
... libunwind: [ OFF ]

...            libdw-dwarf-unwind: [ on  ]
...                          zlib: [ on  ]
...                          lzma: [ on  ]
...                     get_cpuid: [ on  ]
...                           bpf: [ on  ]

The above is the config I used for testing the build.

-- Steve

Tzvetomir Stoyanov (VMware) (24):
tools/lib/traceevent, tools/perf: Rename struct pevent to struct tep_handle tools/lib/traceevent, tools/perf: Rename struct pevent_record to struct tep_record tools/lib/traceevent, tools/perf: Rename pevent plugin related APIs tools/lib/traceevent, tools/perf: Rename pevent alloc / free APIs tools/lib/traceevent, tools/perf: Rename pevent find APIs tools/lib/traceevent, tools/perf: Rename pevent parse APIs tools/lib/traceevent, tools/perf: Rename pevent print APIs tools/lib/traceevent, tools/perf: Rename pevent_read_number_* APIs tools/lib/traceevent, tools/perf: Rename pevent_register_* APIs tools/lib/traceevent, tools/perf: Rename pevent_set_* APIs tools/lib/traceevent, tools/perf: Rename traceevent_* APIs tools/lib/traceevent, tools/perf: Rename enum pevent_flag to enum tep_flag tools/lib/traceevent, tools/lib/lockdep/: Rename enunm pevent_errno to enum tep_errno tools/lib/traceevent: Rename pevent_function* APIs tools/lib/traceevent, tools/perf: Rename traceevent_plugin_* APIs tools/lib/traceevent: Rename pevent_filter* APIs
tools/lib/traceevent: Rename pevent_register / unregister APIs tools/lib/traceevent: Rename pevent_data_ APIs
tools/lib/traceevent: Rename pevent field APIs
tools/lib/traceevent: Rename pevent_find_* APIs
tools/lib/traceevent: Rename various pevent get/set/is APIs tools/lib/traceevent: Rename internal parser related APIs tools/lib/traceevent: Rename various pevent APIs
tools/lib/traceevent: Rename static variables and functions in event-parse.c

----

 tools/lib/lockdep/Makefile                         |   4 +-
 tools/lib/traceevent/Makefile                      |   4 +-
 tools/lib/traceevent/event-parse.c                 | 696 ++++++++++-----------
 tools/lib/traceevent/event-parse.h                 | 458 +++++++-------
 tools/lib/traceevent/event-plugin.c                |  70 +--
 tools/lib/traceevent/parse-filter.c                | 288 ++++-----
 tools/lib/traceevent/plugin_cfg80211.c             |  20 +-
 tools/lib/traceevent/plugin_function.c             |  34 +-
 tools/lib/traceevent/plugin_hrtimer.c              |  56 +-
 tools/lib/traceevent/plugin_jbd2.c                 |  36 +-
 tools/lib/traceevent/plugin_kmem.c                 |  66 +-
 tools/lib/traceevent/plugin_kvm.c                  | 154 ++---
 tools/lib/traceevent/plugin_mac80211.c             |  28 +-
 tools/lib/traceevent/plugin_sched_switch.c         |  60 +-
 tools/lib/traceevent/plugin_scsi.c                 |  24 +-
 tools/lib/traceevent/plugin_xen.c                  |  20 +-
 tools/perf/builtin-kmem.c                          |   6 +-
 tools/perf/builtin-report.c                        |   6 +-
 tools/perf/builtin-script.c                        |   6 +-
 tools/perf/util/data-convert-bt.c                  |   6 +-
 tools/perf/util/evsel.c                            |   2 +-
 tools/perf/util/header.c                           |   6 +-
 tools/perf/util/machine.h                          |   2 +-
 tools/perf/util/python.c                           |  10 +-
 .../perf/util/scripting-engines/trace-event-perl.c |   2 +-
 .../util/scripting-engines/trace-event-python.c    |   6 +-
 tools/perf/util/sort.c                             |  16 +-
 tools/perf/util/sort.h                             |   2 +-
 tools/perf/util/trace-event-parse.c                |  34 +-
 tools/perf/util/trace-event-read.c                 |  44 +-
 tools/perf/util/trace-event-scripting.c            |   4 +-
 tools/perf/util/trace-event.c                      |  28 +-
 tools/perf/util/trace-event.h                      |  20 +-
 33 files changed, 1109 insertions(+), 1109 deletions(-)